Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: fix the typo error #26032

Closed
wants to merge 1 commit into from
Closed

lib: fix the typo error #26032

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 10, 2019 •
edited by ghost
Loading

For recoverable.js: fix a typo error ('the' before 'any').

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the repl Issues and PRs related to the REPL subsystem. label Feb 10, 2019
@lpinca
Copy link
Member

lpinca commented Feb 10, 2019

It might be better to use two different commits as the typo has nothing to do with the other change.

lib: fix the typo error
f42e618 
Fix a typo error ('the' before 'any').
@ghost ghost changed the title lib: fix and merge some chores lib: fix the typo error Feb 10, 2019
@ghost
Copy link
Author

ghost commented Feb 10, 2019

@lpinca: OK, I thought it was nits and now I've forcely pushed one file :)

@lpinca
Copy link
Member

lpinca commented Feb 10, 2019

@Maledong I was suggesting to use 2 different commits, one for the switch statement and one for the typo.

I can only see the typo fix now.

@ghost
Copy link
Author

ghost commented Feb 10, 2019

@lpinca: Ah ha, yes, and this is the splitted submit: #26039.
Thank you, it was too late yesterday and I submitted it now.

mhdawson
mhdawson approved these changes Feb 11, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danbev
Copy link
Contributor

danbev commented Feb 13, 2019

Landed in 048b977.

@danbev danbev closed this Feb 13, 2019
danbev pushed a commit that referenced this pull request Feb 13, 2019
@danbev
lib: fix the typo error
048b977 
Fix a typo error ('the' before 'any').

PR-URL: #26032
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Lance Ball <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Feb 13, 2019
@addaleax
lib: fix the typo error
b1a8927 
Fix a typo error ('the' before 'any').

PR-URL: #26032
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Lance Ball <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@ghost ghost deleted the ChoreFixtures branch February 13, 2019 22:49
@ghost
Copy link
Author

ghost commented Feb 13, 2019

Thanks all!

@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@lpinca @danbev @lance @jasnell @thefourtheye @antsmartian @richardlau @BethGriggs @mhdawson @nodejs-github-bot