Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix icutrim build failure when building small-icu on Big-Endian platforms #2602

Closed
wants to merge 1 commit into from

Conversation

sxa
Copy link
Member

@sxa sxa commented Aug 28, 2015

Fix a build error that occurs when icutrim is run to cut down the ICU locale set on Big-Endian platforms when building with --with-intl=small-icu (which is done by the "make binary" target). This fixes the binary build on POWER platforms. See #2601 for details of the specific error that shows.

Cc @srl295

@Fishrock123 Fishrock123 added build Issues and PRs related to build files or the CI. i18n-api Issues and PRs related to the i18n implementation. labels Aug 28, 2015
@srl295
Copy link
Member

srl295 commented Sep 2, 2015

1135ad0 LGTM.

@mhdawson
Copy link
Member

@mhdawson
Copy link
Member

CI run is good, will land.

mhdawson pushed a commit that referenced this pull request Sep 17, 2015
Fix a build error that occurs when icutrim is run to cut down
the ICU locale set on Big-Endian platforms when building with
--with-intl=small-icu (which is done by the "make binary" target).
This fixes the binary build on POWER platforms.

Fixes: #2601
PR-URL: #2602
Reviewed-By: Steven Loomis <[email protected]>
@mhdawson
Copy link
Member

landed as 1fa0cb8

Fishrock123 pushed a commit that referenced this pull request Sep 20, 2015
Fix a build error that occurs when icutrim is run to cut down
the ICU locale set on Big-Endian platforms when building with
--with-intl=small-icu (which is done by the "make binary" target).
This fixes the binary build on POWER platforms.

Fixes: #2601
PR-URL: #2602
Reviewed-By: Steven Loomis <[email protected]>
@rvagg rvagg mentioned this pull request Sep 22, 2015
@mhdawson
Copy link
Member

Landed in v4.1.1 so closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. i18n-api Issues and PRs related to the i18n implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants