win, build: arm64 port script and doc changes #25995
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
jkunkee
force-pushed
the
arm64-win-build
branch
2 times, most recently
from
6d4196a
to
c1f2ce5
Compare
refack
reviewed
Feb 8, 2019
refack
reviewed
Feb 8, 2019
2 tasks
|
@jkunkee - talk to me about what you might need for arm64 CI/CD for Windows 10? (perhaps offline, perhaps here) I have some resources through @WorksOnArm but we don't yet have Windows 10 for Arm up on any servers. |
|
@vielmetti, in general we need machines--virtual or physical--running Windows 10 on ARM and available on demand as a service for the general public. I'll ping you via email about it. |
joaocgreis
reviewed
Feb 13, 2019
jkunkee
force-pushed
the
arm64-win-build
branch
2 times, most recently
from
3c65a55
to
333ea47
Compare
jkunkee
force-pushed
the
arm64-win-build
branch
2 times, most recently
from
1abe49f
to
7083224
Compare
jkunkee
force-pushed
the
arm64-win-build
branch
from
7083224
to
735d376
Compare
joaocgreis
approved these changes
Mar 4, 2019
joaocgreis
pushed a commit
that referenced
this pull request
Mar 4, 2019
PR-URL: #25995 Reviewed-By: João Reis <[email protected]>
joaocgreis
pushed a commit
that referenced
this pull request
Mar 4, 2019
PR-URL: #25995 Reviewed-By: João Reis <[email protected]>
joaocgreis
pushed a commit
that referenced
this pull request
Mar 4, 2019
PR-URL: #25995 Reviewed-By: João Reis <[email protected]>
joaocgreis
pushed a commit
that referenced
this pull request
Mar 4, 2019
PR-URL: #25995 Reviewed-By: João Reis <[email protected]>
|
Landed in d57c526...26cfaf4 |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 12, 2019
PR-URL: nodejs#25995 Reviewed-By: João Reis <[email protected]>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 12, 2019
PR-URL: nodejs#25995 Reviewed-By: João Reis <[email protected]>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 12, 2019
PR-URL: nodejs#25995 Reviewed-By: João Reis <[email protected]>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 12, 2019
PR-URL: nodejs#25995 Reviewed-By: João Reis <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 16, 2019
PR-URL: #25995 Reviewed-By: João Reis <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 16, 2019
PR-URL: #25995 Reviewed-By: João Reis <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 16, 2019
PR-URL: #25995 Reviewed-By: João Reis <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 16, 2019
PR-URL: #25995 Reviewed-By: João Reis <[email protected]>
Merged
This was referenced May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change lays the groundwork for ARM64 Windows ("Windows 10 on ARM") builds of Node.js.
Build script and configuration files gets new ARM64 Windows sections. The arch-specific check for NASM is scoped to the architectures that rely on it.
The bootstrap script arguments for Visual Studio tool installation are expanded to include ARM64 tools.
Documentation is updated to reflect all of these changes.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes