Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: fix return type in Hash #25936

Closed
wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 5, 2019
src/heap_utils.cc Outdated Show resolved Hide resolved
@gengjiawen gengjiawen force-pushed the fix_type_in_Hash branch 2 times, most recently from 00f859a to f37d729 Compare February 5, 2019 02:42
@danbev
Copy link
Contributor

danbev commented Feb 8, 2019

@addaleax
Copy link
Member

addaleax commented Feb 9, 2019

Landed in ea2350b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants