build: reduce the use of sys.path.insert() in configure.py #25884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
Trott
added
the
python
bnoordhuis
reviewed
Feb 2, 2019
| @@ -24,21 +24,21 @@ | |||
| CC = os.environ.get('CC', 'cc' if sys.platform == 'darwin' else 'gcc') | |||
| CXX = os.environ.get('CXX', 'c++' if sys.platform == 'darwin' else 'g++') | |||
|
|
|||
| sys.path.insert(0, os.path.join('tools', 'gyp', 'pylib')) | |||
| from gyp.common import GetFlavor | |||
| # sys.path.insert(0, os.path.join('tools', 'gyp', 'pylib')) | |||
There was a problem hiding this comment.
Can you remove this? Rule of thumb: don't leave in commented-out code.
addaleax
approved these changes
Feb 6, 2019
danbev
suggested changes
Feb 8, 2019
There was a problem hiding this comment.
I'm getting the following error locally (and on Travis):
$ ./configure && make -j8 test 2> warnings
Traceback (most recent call last):
File "./configure", line 28, in <module>
import configure
File "/Users/danielbevenius/work/nodejs/node/configure.py", line 28, in <module>
from node.tools.gyp.pylib.gyp.common import GetFlavor
ImportError: No module named node.tools.gyp.pylib.gyp.common
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes