Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process: move DEP0062 (node --debug) to end-of-life #25828

Closed
wants to merge 3 commits into from
Closed

process: move DEP0062 (node --debug) to end-of-life #25828

wants to merge 3 commits into from

Commits on Jan 30, 2019

  1. process: exit on --debug and --debug-brk after option parsing 

    Moves the exit of `--debug` and `--debug-brk` earlier, that is,
after the option parsing is done in the C++ land.

Also removes `process._invalidDebug`.
    @joyeecheung
    joyeecheung committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    f772636 View commit details
    Browse the repository at this point in the history

  2. process: move DEP0062 (node --debug) to end-of-life 

    This has already been practically end-of-life since `node --debug`
alone would exit the process. This patch drops support of
`node --inspect --debug-brk` as well.

`node --inspect --debug-brk` has been deprecated since v8,
it has been maintained so that vendors can target Node.js
v6 and above without detecting versions.
The support of `--inspect`, which starts from v6, will reach
end-of-life in April 2019, it should be safe to drop the support
of `--inspect --debug-brk` altogether in v12.

Also removes `process._deprecatedDebugBrk`
    @joyeecheung
    joyeecheung committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    3657440 View commit details
    Browse the repository at this point in the history

  3. fixup! process: move DEP0062 (node --debug) to end-of-life

    @joyeecheung
    joyeecheung committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    1cfc45a View commit details
    Browse the repository at this point in the history