Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove main_isolate #25823

Closed
wants to merge 1 commit into from
Closed

src: remove main_isolate #25823

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

This addresses a TODO comment (fyi @joyeecheung).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2452/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jan 30, 2019
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 1, 2019
@addaleax
Copy link
Member Author

addaleax commented Feb 1, 2019

Rebased. New CI: https://ci.nodejs.org/job/node-test-pull-request/20528/

@addaleax
Copy link
Member Author

addaleax commented Feb 3, 2019

Landed in 363ef3f

@addaleax addaleax closed this Feb 3, 2019
@addaleax addaleax deleted the no-main-isolte branch February 3, 2019 19:52
addaleax added a commit that referenced this pull request Feb 3, 2019
@addaleax
src: remove main_isolate
363ef3f 
PR-URL: #25823
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@addaleax
Copy link
Member Author

addaleax commented Feb 3, 2019

(I’m adding backport-requested-v11.x – this should not be hard to backport, but it would be good to backport other PRs first and have this apply cleanly.)

@targos targos mentioned this pull request Feb 6, 2019
Closed
targos pushed a commit that referenced this pull request Feb 10, 2019
@addaleax @targos
src: remove main_isolate
fd6ce53 
PR-URL: #25823
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@cjihrig cjihrig cjihrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@addaleax @nodejs-github-bot @bnoordhuis @cjihrig @joyeecheung @targos