-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add documentation for request.path #25788
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
http
Issues or PRs related to the http subsystem.
labels
Jan 29, 2019
This comment has been minimized.
This comment has been minimized.
jasnell
approved these changes
Jan 29, 2019
Trott
reviewed
Jan 29, 2019
Co-Authored-By: kei-ito <[email protected]>
I added the commit and edited the description as I noticed that v0.3.6 didn't expose request.path. |
lpinca
approved these changes
Jan 30, 2019
pull bot
pushed a commit
to zys-contrib/node
that referenced
this pull request
Feb 1, 2019
The field has been added in v0.4.0. PR-URL: nodejs#25788 Refs: nodejs@b09c588#diff-1c0f1c434b17b7f8795d44a51a14320aR814 Refs: https://github.com/nodejs/node/blob/380929ec0c4c4004b522bed5e3800ebce2b68bfd/test/parallel/test-http-client-defaults.js Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Landed in 32c7ad6 |
addaleax
pushed a commit
that referenced
this pull request
Feb 1, 2019
The field has been added in v0.4.0. PR-URL: #25788 Refs: b09c588#diff-1c0f1c434b17b7f8795d44a51a14320aR814 Refs: https://github.com/nodejs/node/blob/380929ec0c4c4004b522bed5e3800ebce2b68bfd/test/parallel/test-http-client-defaults.js Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The field has been added in v0.4.0.
Refs: b09c588#diff-1c0f1c434b17b7f8795d44a51a14320aR814
Refs: /test/parallel/test-http-client-defaults.js
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesI ran
make -j4 test
on macOS. But I got the message below: