Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: misc cleanup II #25610

Closed
wants to merge 6 commits into from
Closed

report: misc cleanup II #25610

wants to merge 6 commits into from

Commits on Jan 21, 2019

  1. report: remove internalBinding('config').hasReport 

    The `setup()` method is only called when the `--experimental-report`
option is set. `getOptionValue()` returns `undefined` when
the flag is not defined, so the extra check inside of `setup()` is
redundant.
    @addaleax
    addaleax committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    da03f0f View commit details
    Browse the repository at this point in the history

  2. src: remove unnecessary filename variable

    @addaleax
    addaleax committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    768c1fd View commit details
    Browse the repository at this point in the history

  3. report: roll extra loop iteration in PrintNativeStack()

    @addaleax
    addaleax committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    7e0bed1 View commit details
    Browse the repository at this point in the history

  4. report: downgrade reinterpret_cast to static_cast

    @addaleax
    addaleax committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    3130406 View commit details
    Browse the repository at this point in the history

  5. report: use uv_handle_type_name() to get handle type

    @addaleax
    addaleax committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    ec5ee3e View commit details
    Browse the repository at this point in the history

  6. fixup! report: use uv_handle_type_name() to get handle type

    @addaleax
    addaleax committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    d356f5b View commit details
    Browse the repository at this point in the history