Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: remove InitializeReport() #25598

Closed
wants to merge 1 commit into from
Closed

report: remove InitializeReport() #25598

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2309/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jan 21, 2019
@addaleax
Copy link
Member Author

addaleax commented Jan 21, 2019 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/20234/ (:white_check_mark:)

@addaleax
Copy link
Member Author

Can I get another review?

@addaleax
Copy link
Member Author

Thanks!

Landed in a8d763a

@addaleax addaleax closed this Jan 23, 2019
@addaleax addaleax deleted the report-initialize branch January 23, 2019 16:23
addaleax added a commit that referenced this pull request Jan 23, 2019
@addaleax
report: remove InitializeReport()
a8d763a 
PR-URL: #25598
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@richardlau richardlau mentioned this pull request Jan 23, 2019
Merged
targos pushed a commit that referenced this pull request Jan 24, 2019
@addaleax @targos
report: remove InitializeReport()
4031b5c 
PR-URL: #25598
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil Awaiting requested review from gireeshpunathil

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@addaleax @nodejs-github-bot @cjihrig @richardlau