[v10.x backport] n-api: handle reference delete before finalize #25574
Conversation
nodejs-github-bot
added
c++
mhdawson
changed the title
mhdawson
force-pushed
the
backport-24494-to-v10.x
branch
from
79bd432
to
ffb04fc
Compare
|
CI run against 10.x - https://ci.nodejs.org/job/node-test-pull-request/20198/ |
|
Resume build as I doubt the windows failures are related to this PR: https://ci.nodejs.org/job/node-test-pull-request/20204/ |
|
Failure in earlier CI does look like this known issue: #23277 |
|
One more resume attempt, although the freebsd one is a compile failure in an unrelated file? |
|
I'm guessing maybe something landed earlier in staging that is causing the failure? Trying a CI run against 10.x branch instead to see if the same failure happens there or not. https://ci.nodejs.org/job/node-test-pull-request/20237/ (still to start at time of posting) |
|
Run on FreeBSD of v10.x-staging - https://ci.nodejs.org/job/node-test-commit-freebsd/23523/. If it fails will confirm that its something already on the branch. |
|
@codebytere @BethGriggs looks to me like v10.x-staging, freebsd10-64 fails without my PR ( I think that is also the case for v10.x as well based on the CI ran on this PR rebased onto v10.x). Is this a known issue? I think this PR is good to go as that failure is pre-existing and there are no other failures in the CI run for the PR. |
|
@codebytere, @BethGriggs seems like the problem is this commit: acf7e7d from the discusion here: nodejs/abi-stable-node#358. Sounds like this is being seen by others as well and blocking backports. |
MylesBorins
force-pushed
the
v10.x-staging
branch
from
c1ee936
to
c6cffad
Compare
codebytere
force-pushed
the
v10.x-staging
branch
3 times, most recently
from
2d6e145
to
7840f71
Compare
|
New CI as I think I saw another issue that might have been blocked by the same problem get a green CI:https://ci.nodejs.org/job/node-test-pull-request/20452/ |
|
See I need a rebase , doing that now. |
Crashes were reported during finalization due to the memory for a reference being deleted and the finalizer running after the deletion. This change ensures the deletion of the memory for the reference only occurs after the finalizer has run. Fixes: nodejs/node-addon-api#393 Backport-PR-URL: nodejs#25574 PR-URL: nodejs#24494 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
mhdawson
force-pushed
the
backport-24494-to-v10.x
branch
from
ffb04fc
to
af63c6e
Compare
|
resume build: https://ci.nodejs.org/job/node-test-pull-request/20489/ |
|
Latest CI is good. @codebytere this is good to go. |
Crashes were reported during finalization due to the memory for a reference being deleted and the finalizer running after the deletion. This change ensures the deletion of the memory for the reference only occurs after the finalizer has run. Fixes: nodejs/node-addon-api#393 Backport-PR-URL: #25574 PR-URL: #24494 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
|
Landed on |
Crashes were reported during finalization due to the memory for a reference being deleted and the finalizer running after the deletion. This change ensures the deletion of the memory for the reference only occurs after the finalizer has run. Fixes: nodejs/node-addon-api#393 Backport-PR-URL: #25574 PR-URL: #24494 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Backport of #24494
Crashes were reported during finalization due to
the memory for a reference being deleted and the
finalizer running after the deletion.
This change ensures the deletion of the memory for
the reference only occurs after the finalizer has run.
Fixes: nodejs/node-addon-api#393
Backport-PR-URL: #25574
PR-URL: #24494
Reviewed-By: Anna Henningsen [email protected]
Reviewed-By: Franziska Hinkelmann [email protected]
Reviewed-By: Refael Ackermann [email protected]
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes