test: fix default value for additional param #2553
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Python, the default values of parameters are evaluated only once during their declaration. So, whenever the default parameter is used the same object will be used. Since we use a list, which is a mutable object, this could lead to unexpected results.
|
LGTM 👍 |
| if additional is not None: | ||
| self.additional_flags = additional | ||
| else: | ||
| self.additional_flags = [] |
There was a problem hiding this comment.
You could shorten this to self.additional_flags = additional or [].
There was a problem hiding this comment.
@bnoordhuis Correct but if an empty list is actually passed, we ll still ignore it and create a new list, if we do additional or [] . We don't want that.
There was a problem hiding this comment.
@bnoordhuis ping!
|
LGTM with a suggestion. |
|
Just to confirm: LGTM. A suggestion means you're free to take it or leave it. :-) |
thefourtheye
added a commit
that referenced
this pull request
Sep 15, 2015
In Python, the default values of parameters are evaluated only once during their declaration. So, whenever the default parameter is used the same object will be used. Since we use a list, which is a mutable object, this could lead to unexpected results. PR-URL: #2553 Reviewed-By: Ben Noordhuis <[email protected]>
|
Thanks for the review Ben, landed in 52f84ad. I had changed, the super call of |
thefourtheye
added a commit
that referenced
this pull request
Sep 15, 2015
In Python, the default values of parameters are evaluated only once during their declaration. So, whenever the default parameter is used the same object will be used. Since we use a list, which is a mutable object, this could lead to unexpected results. PR-URL: #2553 Reviewed-By: Ben Noordhuis <[email protected]>
This was referenced Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python, the default values of parameters are evaluated only once
during their declaration. So, whenever the default parameter is used
the same object will be used. Since we use a list, which is a mutable
object, this could lead to unexpected results.
cc @nodejs/build
CI Run: https://jenkins-iojs.nodesource.com/job/node-test-pull-request/169/