Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.x backport] src: re-sort the symbol macros #25500

Closed
wants to merge 1 commit into from
Closed

[v10.x backport] src: re-sort the symbol macros #25500

wants to merge 1 commit into from

Conversation

sam-github
Copy link
Contributor

The symbol macros were almost lexically sorted, but some were misplaced.

PR-URL: #24382
Reviewed-By: Gus Caplan [email protected]
Reviewed-By: Refael Ackermann [email protected]
Reviewed-By: Colin Ihrig [email protected]
Reviewed-By: Franziska Hinkelmann [email protected]
Reviewed-By: Anna Henningsen [email protected]

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@sam-github sadly an error occured when I tried to trigger a build :(

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. v10.x labels Jan 14, 2019
@sam-github sam-github force-pushed the backport-24382-to-10.x branch from 7898552 to e645bcf Compare January 14, 2019 19:42
@sam-github sam-github mentioned this pull request Jan 14, 2019
Merged
2 tasks
@joyeecheung joyeecheung mentioned this pull request Jan 16, 2019
Closed
bnoordhuis
bnoordhuis approved these changes Jan 17, 2019
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM.

@codebytere codebytere force-pushed the v10.x-staging branch 3 times, most recently from 2d6e145 to 7840f71 Compare January 29, 2019 18:12
@sam-github
src: re-sort the symbol macros
c76c3c9 
The symbol macros were almost lexically sorted, but some were misplaced.

Backport-PR-URL: nodejs#25500
PR-URL: nodejs#24382
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@sam-github sam-github force-pushed the backport-24382-to-10.x branch from e645bcf to c76c3c9 Compare February 4, 2019 19:16
@sam-github
Copy link
Contributor Author

@BethGriggs rebased cleanly

BethGriggs pushed a commit that referenced this pull request Feb 5, 2019
@sam-github @BethGriggs
src: re-sort the symbol macros
26f7edb 
The symbol macros were almost lexically sorted, but some were misplaced.

Backport-PR-URL: #25500
PR-URL: #24382
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@BethGriggs
Copy link
Member

Landed on v10.x-staging in 26f7edb

@BethGriggs BethGriggs closed this Feb 5, 2019
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@sam-github @rvagg
src: re-sort the symbol macros
46f5c32 
The symbol macros were almost lexically sorted, but some were misplaced.

Backport-PR-URL: #25500
PR-URL: #24382
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@sam-github sam-github deleted the backport-24382-to-10.x branch March 20, 2019 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sam-github @nodejs-github-bot @BethGriggs @bnoordhuis