-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix two doc errors #2549
doc: fix two doc errors #2549
Conversation
I guess also cc @chrisdickinson for the latter. |
For the first one: I believe that's correct. LGTM |
LGTM |
`process.stdout` always blocks as of 20176a9 `WritableState.buffer` is `getBuffer()` as of 9158666 PR-URL: nodejs#2549 Reviewed-By: Alexis Campailla <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
3dd7ed3
to
892bf65
Compare
`process.stdout` always blocks as of 20176a9 `WritableState.buffer` is `getBuffer()` as of 9158666 PR-URL: #2549 Reviewed-By: Alexis Campailla <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
`process.stdout` always blocks as of 20176a9 `WritableState.buffer` is `getBuffer()` as of 9158666 PR-URL: #2549 Reviewed-By: Alexis Campailla <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
Having the docs say that |
Ugh, this is way to confusing. The call is asynchronous as in the actual write will (likely?) not occur during the function being called. It will later block the process to do the write, however. It is likely to be done in the I/O phase of that tick I believe. That being said, I think there is some js-side data that is updated synchronously which is normally what you'd be checking from the same process. cc @bnoordhuis who likely knows how the heck this actually works |
Refs: #2972 (comment) |
Found these while digging around.
process.stdout
always blocks as of20176a9
WritableState.buffer
isgetBuffer()
as of9158666
cc @orangemocha for the first one. I'm unaware of a case where it wouldn't block now.