Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: remove deprecated crypto._toBuf #25338

Closed
wants to merge 1 commit into from
Closed

crypto: remove deprecated crypto._toBuf #25338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions doc/api/deprecations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2161,15 +2161,18 @@ release.
### DEP0114: crypto._toBuf()
<!-- YAML
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/???
description: End-of-Life.
- version: v11.0.0
pr-url: https://github.com/nodejs/node/pull/22501
description: Runtime deprecation.
-->

Type: Runtime
Type: End-Of-Life

The `crypto._toBuf()` function was not designed to be used by modules outside
of Node.js core and will be removed in the future.
of Node.js core and was removed.

<a id="DEP0115"></a>
### DEP0115: crypto.prng(), crypto.pseudoRandomBytes(), crypto.rng()
Expand Down
7 changes: 1 addition & 6 deletions lib/crypto.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,7 @@ const {
getHashes,
setDefaultEncoding,
setEngine,
timingSafeEqual,
toBuf
timingSafeEqual
} = require('internal/crypto/util');
const Certificate = require('internal/crypto/certificate');

Expand Down Expand Up @@ -216,10 +215,6 @@ function getFipsForced() {
}

Object.defineProperties(exports, {
_toBuf: {
enumerable: false,
value: deprecate(toBuf, 'crypto._toBuf is deprecated.', 'DEP0114')
},
createCipher: {
enumerable: false,
value: deprecate(createCipher,
Expand Down
8 changes: 1 addition & 7 deletions test/parallel/test-crypto.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@ if (!common.hasCrypto)

common.expectWarning({
DeprecationWarning: [
['crypto.createCipher is deprecated.', 'DEP0106'],
['crypto._toBuf is deprecated.', 'DEP0114']
['crypto.createCipher is deprecated.', 'DEP0106']
]
});

Expand Down Expand Up @@ -301,8 +300,3 @@ testEncoding({
testEncoding({
defaultEncoding: 'latin1'
}, assertionHashLatin1);

{
// Test that the exported _toBuf function is deprecated.
crypto._toBuf(Buffer.alloc(0));
}