Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: Remove exec, has been deprecated for years #2530

Closed
wants to merge 1 commit into from
Closed

util: Remove exec, has been deprecated for years #2530

wants to merge 1 commit into from

Conversation

geek
Copy link
Member

@geek geek commented Aug 24, 2015

@brendanashworth brendanashworth added util Issues and PRs related to the built-in util module. semver-major PRs that contain breaking changes and should be released in the next major version. labels Aug 24, 2015
@chrisdickinson
Copy link
Contributor

Adding this to the list of things to check.

@mscdex
Copy link
Contributor

mscdex commented Aug 25, 2015

LGTM

@geek
Copy link
Member Author

geek commented Sep 1, 2015

@chrisdickinson do you have a tool that runs a check? If so, can you share the code?

@targos
Copy link
Member

targos commented Oct 9, 2015

@chrisdickinson could you check this one ?

@jasnell
Copy link
Member

jasnell commented Nov 5, 2015

@chrisdickinson ... ping. were you ever able to get around to this?

@jasnell jasnell added stalled Issues and PRs that are stalled. ctc-agenda labels Nov 16, 2015
@jasnell
Copy link
Member

jasnell commented Nov 18, 2015

Putting this on the ctc-agenda tomorrow for a quick sanity check. Don't believe it's controversial at all but worth a double check

@jasnell jasnell mentioned this pull request Nov 18, 2015
Closed
@cjihrig
Copy link
Contributor

cjihrig commented Nov 18, 2015

LGTM

1 similar comment
@jasnell
Copy link
Member

jasnell commented Nov 18, 2015

LGTM

geek added a commit that referenced this pull request Nov 18, 2015
@geek @jasnell
util: Remove exec, has been deprecated for years
4cf19ad 
PR-URL: #2530
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell jasnell removed ctc-agenda stalled Issues and PRs that are stalled. labels Nov 18, 2015
@jasnell
Copy link
Member

jasnell commented Nov 18, 2015

Landed in 4cf19ad.

@jasnell jasnell closed this Nov 18, 2015
@Fishrock123 Fishrock123 mentioned this pull request Nov 26, 2015
Closed
@Fishrock123 Fishrock123 mentioned this pull request Dec 15, 2015
Closed
@jasnell jasnell mentioned this pull request Mar 17, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
semver-major PRs that contain breaking changes and should be released in the next major version. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@geek @chrisdickinson @mscdex @targos @jasnell @cjihrig @brendanashworth