Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coverage: fix broken coverage setup #25289

Merged
merged 3 commits into from
Jan 2, 2019
Merged

coverage: fix broken coverage setup #25289

merged 3 commits into from
Jan 2, 2019

Commits on Jan 2, 2019

  1. coverage: use process._rawDebug() during setup 

    console is not ready to use at this point in the bootstrapping
process, so switch to process._rawDebug() instead.

PR-URL: nodejs#25289
Fixes: nodejs#25287
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
    @cjihrig
    cjihrig committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    d32f769 View commit details
    Browse the repository at this point in the history

  2. coverage: pass cwd to path.resolve() in setup 

    During coverage setup, path.resolve() is called.
path.resolve() can potentially call process.cwd(), which
hasn't been bootstrapped yet. This commit passes the
current working directory directly so that path.resolve()
doesn't attempt to compute it.

PR-URL: nodejs#25289
Fixes: nodejs#25287
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
    @cjihrig
    cjihrig committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    a779ee4 View commit details
    Browse the repository at this point in the history

  3. test: make test-v8-coverage.js more strict 

    Update the coverage test to verify that nothing is printed to
stderr (which happens when coverage errors happen). Also add a
test case to verify that non-absolute coverage paths work.

PR-URL: nodejs#25289
Fixes: nodejs#25287
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
    @cjihrig
    cjihrig committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    8881a5a View commit details
    Browse the repository at this point in the history