process: move setup of process warnings into node.js #25263
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To clarify the side effects and conditions of the warning setup during bootstrap.
nodejs-github-bot
added
the
process
devsnek
approved these changes
Dec 29, 2018
addaleax
approved these changes
Dec 30, 2018
addaleax
added
the
author ready
JungMinu
approved these changes
Dec 31, 2018
|
Landed in 0878b61 |
joyeecheung
added a commit
that referenced
this pull request
Dec 31, 2018
To clarify the side effects and conditions of the warning setup during bootstrap. PR-URL: #25263 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
|
Should this be backported to |
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
To clarify the side effects and conditions of the warning setup during bootstrap. PR-URL: nodejs#25263 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
|
ping @joyeecheung |
antsmartian
added a commit
to antsmartian/node
that referenced
this pull request
Feb 10, 2019
To clarify the side effects and conditions of the warning setup during bootstrap. PR-URL: nodejs#25263 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
targos
pushed a commit
that referenced
this pull request
Feb 10, 2019
To clarify the side effects and conditions of the warning setup during bootstrap. PR-URL: #25263 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Backport-PR-URL: #26025
Merged
This was referenced Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For ease of review please use https://github.com/nodejs/node/pull/25263/files?w=1 to skip indentation-only changes.
To clarify the side effects and conditions of the warning setup
during bootstrap.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes