Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix warning in cares_wrap.cc #25230

Merged
merged 1 commit into from
Dec 31, 2018
Merged

src: fix warning in cares_wrap.cc #25230

merged 1 commit into from
Dec 31, 2018

Commits on Dec 31, 2018

  1. src: fix warning in cares_wrap.cc 

    This commit fixes the following warning:

./src/cares_wrap.cc:1268:5: warning: comparison of integers of
    different signs: 'uint32_t' (aka 'unsigned int') and 'int'
    [-Wsign-compare]
    CHECK_EQ(ret->Length(), a_count + aaaa_count);

PR-URL: nodejs#25230
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
    @cjihrig
    cjihrig committed Dec 31, 2018
    Configuration menu
    Copy the full SHA
    da9a4d0 View commit details
    Browse the repository at this point in the history