Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: prepare test-whatwg-encoding-* to be ported to WPT if possible #25155

Closed
wants to merge 5 commits into from
Closed

test: prepare test-whatwg-encoding-* to be ported to WPT if possible #25155

wants to merge 5 commits into from

Commits on Dec 20, 2018

  1. test: split test-whatwg-encoding-textdecoder.js 

    Split test-whatwg-encoding-textdecoder.js into:

- `test-whatwg-encoding-custom-textdecoder.js` which tests
  Node.js-specific behaviors
- `test-whatwg-encoding-custom-textdecoder-api-invalid-label.js` which is
  a customized version of the WPT counterpart
- `test-whatwg-encoding-custom-api-basics.js` which is the part of
  `test-whatwg-encoding-api-basics.js` that can be run without ICU
- `test-whatwg-encoding-api-basics.js` which can be replaced with WPT
  later.
    @joyeecheung
    joyeecheung committed Dec 20, 2018
    Configuration menu
    Copy the full SHA
    71e9d46 View commit details
    Browse the repository at this point in the history

  2. test: split test-whatwg-encoding-textdecoder-fatal.js 

    Split `test-whatwg-encoding-textdecoder-fatal.js` into

- `test-whatwg-encoding-custom-textdecoder-fatal.js` which
  is a customized version of the WPT that tests for Node.js-specific
  error codes.
- `test-whatwg-encoding-custom-textdecoder-invalid-arg` which
  tests `ERR_INVALID_ARG_TYPE`
    @joyeecheung
    joyeecheung committed Dec 20, 2018
    Configuration menu
    Copy the full SHA
    7d141f8 View commit details
    Browse the repository at this point in the history

  3. test: split encoding tests where some cases can be run without ICU 

    Split the following tests:

- `test-whatwg-encoding-textdecoder-utf16-surrogates.js`
- `test-whatwg-encoding-textdecoder-ignorebom.js`
- `test-whatwg-encoding-textdecoder-streaming.js`

Each into two files: one that can be run without ICU and one that has
to be run with ICU. The latter can be replaced with WPT later.
    @joyeecheung
    joyeecheung committed Dec 20, 2018
    Configuration menu
    Copy the full SHA
    6a9da16 View commit details
    Browse the repository at this point in the history

  4. test: rename custom encoding tests that cannot be replaced by WPT

    @joyeecheung
    joyeecheung committed Dec 20, 2018
    Configuration menu
    Copy the full SHA
    d70ad5f View commit details
    Browse the repository at this point in the history

  5. test: add TODO to encoding tests that can be replaced with WPT

    @joyeecheung
    joyeecheung committed Dec 20, 2018
    Configuration menu
    Copy the full SHA
    48c74f1 View commit details
    Browse the repository at this point in the history