src: add .code and SSL specific error properties

[sam-github]

SSL errors have a long structured message, but lacked the standard .code
property which can be used for stable comparisons. Add a code
property, as well as the 3 string components of an SSL error: reason,
library, and function.

This is WIP, TBD is move the property strings to the isolate, and add docs and more tests.

I've seen a reasonable amount of code that is doing string matching on the error string, looking for the reason part, I think exposing the properties makes more sense. Also, I think the intention is for all Errors to expose .code properties for stable programmatic inspection.

I've gone some way to exposing these properties for node_crypto.cc, too, but I'm not done. Once this PR lands I'll keep working on it.

/to @nodejs/crypto

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[nodejs-github-bot]

@sam-github build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1983/pipeline

[sam-github]

@jasnell PTAL

[danbev]

@sam-github LGTM apart from I'm seeing the same test failures locally as reported by the CI run.

$ out/Release/node --tls-v1.1 /Users/danielbevenius/work/nodejs/node/test/parallel/test-tls-cli-min-version-1.1.js
assert.js:86
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected

+ undefined
- 'ERR_SSL_VERSION_TOO_LOW'
    at common.mustCall (/Users/danielbevenius/work/nodejs/node/test/parallel/test-tls-min-max-version.js:31:14)
    at /Users/danielbevenius/work/nodejs/node/test/common/index.js:373:15
    at /Users/danielbevenius/work/nodejs/node/test/common/index.js:373:15
    at maybeCallback (/Users/danielbevenius/work/nodejs/node/test/fixtures/tls-connect.js:97:7)
    at Server.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/fixtures/tls-connect.js:84:7)
    at Server.emit (events.js:188:13)
    at TLSSocket.onSocketTLSError (_tls_wrap.js:728:29)
    at TLSSocket.emit (events.js:188:13)
    at TLSSocket._tlsError (_tls_wrap.js:608:8)
    at TLSSocket.emit (events.js:188:13)

[addaleax]

LGTM with a comment

[sam-github]

@danbev Oops, reordered the error number peek to after the error message long-form printf while addressing some comments, which doesn't work (printf clears the err number). Tests are passing again locally, lets see how CI does.

[sam-github]

ci: https://ci.nodejs.org/job/node-test-pull-request/19843/

[sam-github]

Landed in ca9c0c9

[addaleax]

Should this be backported to v11.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

[sam-github]

Depends on #24729, semver-major, so not a backport candidate.