Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: migrate process.binding to internalBinding for misc. #24952

Closed
wants to merge 12 commits into from
+52 −25
Closed

test: migrate process.binding to internalBinding for misc. #24952

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
cca74a4
lib: migrate process.binding to internalBinding for misc modules
BeniCheni Dec 11, 2018
6b348d3
src: revert incorrect internalBinding back to process.binding
BeniCheni Dec 15, 2018
bc891a7
test: update require os constants' signals child process spawnsync tests
BeniCheni Dec 17, 2018
1fa0d8f
test: revert to process.binding in test-process-binding.js
BeniCheni Dec 17, 2018
15c5aea
test: update require fs constants in test-process-constants-noatime.js
BeniCheni Dec 17, 2018
081db81
test: add semicolon in test-child-process-spawnsync-validation-errors.js
BeniCheni Dec 17, 2018
741e63d
Update test/parallel/test-fs-readdir-types.js
joyeecheung Dec 17, 2018
0f4db2d
test: update require os constants in test-dgram-bind-fd.js
joyeecheung Dec 17, 2018
63a7690
test: remove unused flag in child process spawnsync validation errors…
BeniCheni Feb 23, 2019
ae788ad
test: enable common.hasCrypto test for internal binding whitelist test
BeniCheni Feb 27, 2019
d9f1730
fixup
addaleax Mar 4, 2019
feddd9d
fixup
addaleax Mar 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update test/parallel/test-fs-readdir-types.js 
Co-Authored-By: BeniCheni <benjaminlchen@gmail.com>
@joyeecheung @BeniCheni
joyeecheung and BeniCheni committed Feb 27, 2019
commit 741e63d704b7be7f7b135adee1c6b5be71f1d1a2
2 changes: 1 addition & 1 deletion test/parallel/test-fs-readdir-types.js
View file
Original file line number Diff line number Diff line change
@@ -12,7 +12,7 @@ const binding = internalBinding('fs');

const readdirDir = tmpdir.path;
const files = ['empty', 'files', 'for', 'just', 'testing'];
const constants = internalBinding('constants').fs;
const constants = require('fs').constants;
const types = {
isDirectory: constants.UV_DIRENT_DIR,
isFile: constants.UV_DIRENT_FILE,