Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: mention util depth default change #24805

Closed
wants to merge 2 commits into from

Conversation

BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Dec 3, 2018

This was missed when reverting a former commit. To make sure the
history is kept in place, this just adds a new entry to state the
revert.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

This was missed when reverting a former commit. To make sure the
history is kept in place, this just adds a new entry to state the
revert.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. util Issues and PRs related to the built-in util module. labels Dec 3, 2018
@BridgeAR
Copy link
Member Author

BridgeAR commented Dec 4, 2018

@nodejs/documentation PTAL

@BridgeAR
Copy link
Member Author

BridgeAR commented Dec 5, 2018

This needs another LG.

doc/api/util.md Outdated Show resolved Hide resolved
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 5, 2018
@BridgeAR
Copy link
Member Author

BridgeAR commented Dec 5, 2018

@Trott
Copy link
Member

Trott commented Dec 5, 2018

Landed in 2a55e71

@Trott Trott closed this Dec 5, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 5, 2018
This was missed when reverting a former commit. To make sure the
history is kept in place, this just adds a new entry to state the
revert.

PR-URL: nodejs#24805
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
BridgeAR added a commit that referenced this pull request Dec 6, 2018
This was missed when reverting a former commit. To make sure the
history is kept in place, this just adds a new entry to state the
revert.

PR-URL: #24805
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 6, 2018
4 tasks
BridgeAR added a commit that referenced this pull request Dec 7, 2018
This was missed when reverting a former commit. To make sure the
history is kept in place, this just adds a new entry to state the
revert.

PR-URL: #24805
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
BridgeAR added a commit that referenced this pull request Dec 7, 2018
This was missed when reverting a former commit. To make sure the
history is kept in place, this just adds a new entry to state the
revert.

PR-URL: #24805
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
This was missed when reverting a former commit. To make sure the
history is kept in place, this just adds a new entry to state the
revert.

PR-URL: nodejs#24805
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@BridgeAR BridgeAR deleted the revert-util-change branch January 20, 2020 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. util Issues and PRs related to the built-in util module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants