Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert,util: fix comparison #24749

Closed
wants to merge 3 commits into from
Closed

assert,util: fix comparison #24749

wants to merge 3 commits into from

Conversation

BridgeAR
Copy link
Member

Please have a look at the commit messages.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@BridgeAR
assert: fix loose deepEqual map comparison
2a21991 
Loose map comparison had an logic error. It will now be properly
compared.
@BridgeAR
assert,util: fix sparse array comparison
02c2bd7 
Comparing sparse arrays did not work properly. That is fixed and
tests were added to verify that everything works as expected.

This had an impact on `util.isDeepStrictEqual()` and
`assert.deepStrictEqual()` and their counterpart
`assert.notDeepStrictEqual()`.
@BridgeAR
test: improve comparison coverage to 100%
d851e08
@nodejs-github-bot
Copy link
Collaborator

@BridgeAR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1743/pipeline

@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Nov 30, 2018
@BridgeAR
Copy link
Member Author

CI https://ci.nodejs.org/job/node-test-pull-request/19082/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 30, 2018
@BridgeAR
Copy link
Member Author

BridgeAR commented Dec 3, 2018 •
edited
Loading

Resumed build https://ci.nodejs.org/job/node-test-commit/23891/ ✔️

BridgeAR added a commit to BridgeAR/node that referenced this pull request Dec 3, 2018
@BridgeAR
assert: fix loose deepEqual map comparison
2eff120 
Loose map comparison had an logic error. It will now be properly
compared.

PR-URL: nodejs#24749
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Dec 3, 2018
@BridgeAR
assert,util: fix sparse array comparison
4dd56a3 
Comparing sparse arrays did not work properly. That is fixed and
tests were added to verify that everything works as expected.

This had an impact on `util.isDeepStrictEqual()` and
`assert.deepStrictEqual()` and their counterpart
`assert.notDeepStrictEqual()`.

PR-URL: nodejs#24749
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Dec 3, 2018
@BridgeAR
test: improve comparison coverage to 100%
2f11fe3 
PR-URL: nodejs#24749
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@BridgeAR
Copy link
Member Author

BridgeAR commented Dec 3, 2018

Landed in e00639e...2f11fe3

@BridgeAR BridgeAR closed this Dec 3, 2018
BridgeAR added a commit that referenced this pull request Dec 5, 2018
@BridgeAR
assert: fix loose deepEqual map comparison
7fb8d31 
Loose map comparison had an logic error. It will now be properly
compared.

PR-URL: #24749
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
BridgeAR added a commit that referenced this pull request Dec 5, 2018
@BridgeAR
assert,util: fix sparse array comparison
8905518 
Comparing sparse arrays did not work properly. That is fixed and
tests were added to verify that everything works as expected.

This had an impact on `util.isDeepStrictEqual()` and
`assert.deepStrictEqual()` and their counterpart
`assert.notDeepStrictEqual()`.

PR-URL: #24749
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
BridgeAR added a commit that referenced this pull request Dec 5, 2018
@BridgeAR
test: improve comparison coverage to 100%
5f58928 
PR-URL: #24749
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@BridgeAR @refack
assert: fix loose deepEqual map comparison
a0740f1 
Loose map comparison had an logic error. It will now be properly
compared.

PR-URL: nodejs#24749
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@BridgeAR @refack
assert,util: fix sparse array comparison
6ee8d61 
Comparing sparse arrays did not work properly. That is fixed and
tests were added to verify that everything works as expected.

This had an impact on `util.isDeepStrictEqual()` and
`assert.deepStrictEqual()` and their counterpart
`assert.notDeepStrictEqual()`.

PR-URL: nodejs#24749
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@BridgeAR @refack
test: improve comparison coverage to 100%
781764c 
PR-URL: nodejs#24749
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@BridgeAR @BethGriggs
assert: fix loose deepEqual map comparison
732088d 
Loose map comparison had an logic error. It will now be properly
compared.

PR-URL: #24749
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@BridgeAR @BethGriggs
assert,util: fix sparse array comparison
5a81a4f 
Comparing sparse arrays did not work properly. That is fixed and
tests were added to verify that everything works as expected.

This had an impact on `util.isDeepStrictEqual()` and
`assert.deepStrictEqual()` and their counterpart
`assert.notDeepStrictEqual()`.

PR-URL: #24749
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@BridgeAR @BethGriggs
test: improve comparison coverage to 100%
6be2d61 
PR-URL: #24749
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
@BridgeAR @BethGriggs
assert: fix loose deepEqual map comparison
b461597 
Loose map comparison had an logic error. It will now be properly
compared.

PR-URL: #24749
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
@BridgeAR @BethGriggs
assert,util: fix sparse array comparison
6fe174d 
Comparing sparse arrays did not work properly. That is fixed and
tests were added to verify that everything works as expected.

This had an impact on `util.isDeepStrictEqual()` and
`assert.deepStrictEqual()` and their counterpart
`assert.notDeepStrictEqual()`.

PR-URL: #24749
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@BridgeAR @rvagg
assert: fix loose deepEqual map comparison
9da4af7 
Loose map comparison had an logic error. It will now be properly
compared.

PR-URL: #24749
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@BridgeAR @rvagg
assert,util: fix sparse array comparison
30aa8b2 
Comparing sparse arrays did not work properly. That is fixed and
tests were added to verify that everything works as expected.

This had an impact on `util.isDeepStrictEqual()` and
`assert.deepStrictEqual()` and their counterpart
`assert.notDeepStrictEqual()`.

PR-URL: #24749
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@BridgeAR BridgeAR deleted the fix-comparison branch January 20, 2020 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BridgeAR @nodejs-github-bot @addaleax @targos @BethGriggs