Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: increase assert test coverage #24745

Closed
wants to merge 1 commit into from
Closed

test: increase assert test coverage #24745

wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

Just a test case that I used as an example how to solve coverage tasks.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@BridgeAR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1739/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 30, 2018
mhdawson
mhdawson approved these changes Nov 30, 2018
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BridgeAR
Copy link
Member Author

CI https://ci.nodejs.org/job/node-test-pull-request/19090/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 30, 2018
@Trott
Copy link
Member

Trott commented Dec 2, 2018 •
edited by danbev
Loading

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19125/ ✔️

@danbev
Copy link
Contributor

danbev commented Dec 3, 2018

Landed in 15b0247.

@danbev danbev closed this Dec 3, 2018
danbev pushed a commit that referenced this pull request Dec 3, 2018
@BridgeAR @danbev
test: increase assert test coverage
15b0247 
PR-URL: #24745
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
BridgeAR added a commit that referenced this pull request Dec 5, 2018
@BridgeAR
test: increase assert test coverage
2916b59 
PR-URL: #24745
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@BridgeAR @refack
test: increase assert test coverage
5cbac36 
PR-URL: nodejs#24745
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@BridgeAR BridgeAR deleted the increase-assert-coverage branch January 20, 2020 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@targos targos targos approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@BridgeAR @nodejs-github-bot @Trott @danbev @addaleax @targos @mhdawson @BethGriggs