[v8.x backport] doc: correct async_hooks resource names #24684
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
async_hooks
2 tasks
|
Needs a rebase or something? Seems to have far too many commits. |
Correct async hooks resource names to match the implementation: `TCPSERVER` => `TCPSERVERWRAP` Refs: #17157
|
No idea what exactly I did wrong but it should be corrected now. |
BethGriggs
approved these changes
Dec 3, 2018
BethGriggs
pushed a commit
that referenced
this pull request
Dec 3, 2018
Correct async hooks resource names to match the implementation: `TCPSERVER` => `TCPSERVERWRAP` Refs: #17157 PR-URL: #24684 Refs: #17157 Refs: #24001 Reviewed-By: Beth Griggs <[email protected]>
|
Landed in f5683a9 |
Merged
This was referenced Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct async hooks resource names to match the implementation:
TCPSERVER=>TCPSERVERWRAPRefs: #17157
Refs: #24001
Checklist