Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix the arguments order in assert.strictEqual #24626

Closed
wants to merge 1 commit into from
Closed

test: fix the arguments order in assert.strictEqual #24626

wants to merge 1 commit into from

Conversation

rt33
Copy link
Contributor

@rt33 rt33 commented Nov 24, 2018

Update strictEqual arguments order

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 24, 2018
@Leko Leko added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 24, 2018
@gireeshpunathil
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18954/

@gireeshpunathil
Copy link
Member

fast-track? pls 👍

@Trott
Copy link
Member

Trott commented Nov 29, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19018/

@Trott
Copy link
Member

Trott commented Nov 29, 2018

Landed in c481799

@Trott Trott closed this Nov 29, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 29, 2018
@rt33 @Trott
test: fix the arguments order in assert.strictEqual
c481799 
PR-URL: nodejs#24626
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
targos pushed a commit that referenced this pull request Nov 29, 2018
@rt33 @targos
test: fix the arguments order in assert.strictEqual
969ae7a 
PR-URL: #24626
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@rt33 @refack
test: fix the arguments order in assert.strictEqual
834c9e5 
PR-URL: nodejs#24626
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@rt33 @BethGriggs
test: fix the arguments order in assert.strictEqual
9f66105 
PR-URL: #24626
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@rt33 @rvagg
test: fix the arguments order in assert.strictEqual
1d94f3e 
PR-URL: #24626
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

@Leko Leko Leko approved these changes

@lpinca lpinca lpinca approved these changes

@watilde watilde watilde approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@rt33 @gireeshpunathil @Trott @fhinkel @Leko @lpinca @watilde @cjihrig @nodejs-github-bot