Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: mark napi_add_finalizer experimental #24572

Closed
wants to merge 1 commit into from
Closed

doc: mark napi_add_finalizer experimental #24572

wants to merge 1 commit into from

Conversation

mhdawson
Copy link
Member

This was missed when the function was added. As it
is experimental in the code it should also be
experimental in the docs.

Fixes: #24509

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@mhdawson
doc: mark napi_add_finalizer experimental
98954fd 
This was missed when the function was added. As it
is experimental in the code it should also be
experimental in the docs.

Fixes: nodejs#24509
@nodejs-github-bot
Copy link
Collaborator

@mhdawson build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1679/pipeline

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. labels Nov 22, 2018
@mhdawson mhdawson mentioned this pull request Nov 22, 2018
Closed
@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 22, 2018
@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 23, 2018
@Trott
Copy link
Member

Trott commented Nov 24, 2018

Landed in ce890a0

@Trott Trott closed this Nov 24, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 24, 2018
@mhdawson @Trott
doc: mark napi_add_finalizer experimental
ce890a0 
This was missed when the function was added. As it
is experimental in the code it should also be
experimental in the docs.

Fixes: nodejs#24509
PR-URL: nodejs#24572
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Nov 24, 2018
@mhdawson @targos
doc: mark napi_add_finalizer experimental
d5b7f99 
This was missed when the function was added. As it
is experimental in the code it should also be
experimental in the docs.

Fixes: #24509
PR-URL: #24572
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@mhdawson @rvagg
doc: mark napi_add_finalizer experimental
5796c6a 
This was missed when the function was added. As it
is experimental in the code it should also be
experimental in the docs.

Fixes: #24509
PR-URL: #24572
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@mhdawson @refack
doc: mark napi_add_finalizer experimental
d5230f8 
This was missed when the function was added. As it
is experimental in the code it should also be
experimental in the docs.

Fixes: nodejs#24509
PR-URL: nodejs#24572
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 11, 2019
@mhdawson @BethGriggs
doc: mark napi_add_finalizer experimental
dd5bfd7 
This was missed when the function was added. As it
is experimental in the code it should also be
experimental in the docs.

Fixes: #24509
PR-URL: #24572
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@mhdawson @rvagg
doc: mark napi_add_finalizer experimental
32d8622 
This was missed when the function was added. As it
is experimental in the code it should also be
experimental in the docs.

Fixes: #24509
PR-URL: #24572
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@mhdawson mhdawson deleted the exp-doc branch September 30, 2019 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@legendecas legendecas legendecas approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

n-api: experimental napi_add_finalizer documented as stable api
8 participants
@mhdawson @nodejs-github-bot @vsemozhetbyt @Trott @lpinca @cjihrig @legendecas @BethGriggs