doc: edit COLLABORATOR_GUIDE.md on closing issues #24477
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the COLLABORATOR_GUIDE.md text on closing issues clearer. (Make it clear that all the text refers to issues *and* pull requests, etc.)
|
@Trott sadly an error occured when I tried to trigger a build :( |
starkwang
approved these changes
Nov 19, 2018
addaleax
approved these changes
Nov 19, 2018
jasnell
reviewed
Nov 19, 2018
| future of the Node.js project. Where this is unclear, leave the issue or pull | ||
| request open for several days to allow for discussion. Where this does not yield | ||
| evidence that the issue or pull request has relevance, close it. Remember that | ||
| issues and pull requests can always be re-opened if necessary. |
There was a problem hiding this comment.
Perhaps we should say something about the use of the stalled label in here?
cjihrig
approved these changes
Nov 19, 2018
fhinkel
approved these changes
Nov 20, 2018
lpinca
approved these changes
Nov 20, 2018
|
Landed in 0759b57 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Nov 21, 2018
Make the COLLABORATOR_GUIDE.md text on closing issues clearer. (Make it clear that all the text refers to issues *and* pull requests, etc.) PR-URL: nodejs#24477 Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 21, 2018
Make the COLLABORATOR_GUIDE.md text on closing issues clearer. (Make it clear that all the text refers to issues *and* pull requests, etc.) PR-URL: #24477 Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
Make the COLLABORATOR_GUIDE.md text on closing issues clearer. (Make it clear that all the text refers to issues *and* pull requests, etc.) PR-URL: #24477 Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Dec 7, 2018
codebytere
pushed a commit
that referenced
this pull request
Jan 13, 2019
Make the COLLABORATOR_GUIDE.md text on closing issues clearer. (Make it clear that all the text refers to issues *and* pull requests, etc.) PR-URL: #24477 Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Make the COLLABORATOR_GUIDE.md text on closing issues clearer. (Make it clear that all the text refers to issues *and* pull requests, etc.) PR-URL: nodejs#24477 Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jan 29, 2019
Make the COLLABORATOR_GUIDE.md text on closing issues clearer. (Make it clear that all the text refers to issues *and* pull requests, etc.) PR-URL: #24477 Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Jan 29, 2019
This was referenced Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the COLLABORATOR_GUIDE.md text on closing issues clearer. (Make it clear that all the text refers to issues and pull requests, etc.)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes