Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: elevate v8 namespaces of repeated references #24460

Closed
wants to merge 1 commit into from
Closed

src: elevate v8 namespaces of repeated references #24460

wants to merge 1 commit into from
+41 −32

Conversation

leeight
Copy link
Contributor

@leeight leeight commented Nov 18, 2018 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 18, 2018
@leeight leeight force-pushed the elevate-v8 branch 2 times, most recently from 7fec354 to fd825ce Compare November 18, 2018 10:14
@leeight leeight changed the title env: elevate v8 namespaces of repeated references src: elevate v8 namespaces of repeated references Nov 18, 2018
@refack
Copy link
Contributor

refack commented Nov 18, 2018

Hello @leeight and welcome. Thank you very much for your contribution 🥇
If you are not familiar with our review and landing process, it's covered in CONTRIBUTING.md

P.S. If you have any questions you can also feel free to contact me directly.

@leeight
Copy link
Contributor Author

leeight commented Nov 18, 2018

Hi @refack Thank you. 🤝

@refack refack added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 18, 2018
@refack
Copy link
Contributor

refack commented Nov 18, 2018

Reviews please 👍 if you are in favor of fast-tracking this PR.

@refack
Copy link
Contributor

refack commented Nov 18, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1651/

@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18727/

@Trott
Copy link
Member

Trott commented Nov 19, 2018

Landed in 69ccbd2

@Trott Trott closed this Nov 19, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 19, 2018
@leeight @Trott
src: elevate v8 namespaces of repeated references
69ccbd2 
PR-URL: nodejs#24460

Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Nov 19, 2018
@leeight @targos
src: elevate v8 namespaces of repeated references
2b649ca 
PR-URL: #24460

Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@leeight @rvagg
src: elevate v8 namespaces of repeated references
873dee9 
PR-URL: #24460

Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@leeight @refack
src: elevate v8 namespaces of repeated references
a71df24 
PR-URL: nodejs#24460

Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@leeight @refack @addaleax @Trott @cjihrig @trivikr @BethGriggs @nodejs-github-bot