Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#JSARROW8 replace anonymous closure function with arrow function. #24435

Closed
wants to merge 1 commit into from
Closed

#JSARROW8 replace anonymous closure function with arrow function. #24435

wants to merge 1 commit into from

Conversation

snofty
Copy link
Contributor

@snofty snofty commented Nov 17, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 17, 2018
@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 17, 2018
targos
targos approved these changes Nov 17, 2018
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM.

Commit message should look like test: replace anonymous closure function with arrow function

@targos
Copy link
Member

targos commented Nov 17, 2018

👍 to fast-track

@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 17, 2018
@gireeshpunathil
Copy link
Member

@snofty -

https://travis-ci.com/nodejs/node/jobs/159275252#L701
https://travis-ci.com/nodejs/node/jobs/159275252#L702

the commit message is not conforming to the guidelines, it should start with the subsystem name, in this case test. Also, number of characters.

guidelines:

https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines

It is something that we can do while landing; but appreciate if you make an attempt, as doing so strengthens the learning, to the spirit of the code & learn, thanks!

@Trott
Copy link
Member

Trott commented Nov 19, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18773/

Trott pushed a commit to Trott/io.js that referenced this pull request Nov 20, 2018
@snofty @Trott
test: replace anonymous closure function with arrow function
8e4688a 
PR-URL: nodejs#24435
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@Trott
Copy link
Member

Trott commented Nov 20, 2018

Landed in 8e4688a.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Nov 20, 2018
targos pushed a commit that referenced this pull request Nov 20, 2018
@snofty @targos
test: replace anonymous closure function with arrow function
cdafa5b 
PR-URL: #24435
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@snofty @rvagg
test: replace anonymous closure function with arrow function
7d743e6 
PR-URL: #24435
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Jan 13, 2019
@snofty @codebytere
test: replace anonymous closure function with arrow function
200f127 
PR-URL: #24435
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@snofty @refack
test: replace anonymous closure function with arrow function
df0c4fd 
PR-URL: nodejs#24435
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@codebytere codebytere mentioned this pull request Jan 15, 2019
Merged
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@snofty @codebytere
test: replace anonymous closure function with arrow function
f129e2c 
PR-URL: #24435
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@sagirk sagirk sagirk approved these changes

@oyyd oyyd oyyd approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.