Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: change callback function to arrow function #24421

Closed
wants to merge 1 commit into from
Closed

test: change callback function to arrow function #24421

wants to merge 1 commit into from

Conversation

lshanmug
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 17, 2018
oyyd
oyyd approved these changes Nov 17, 2018
View reviewed changes
Copy link
Contributor

@oyyd oyyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@oyyd oyyd added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 17, 2018
@targos
Copy link
Member

targos commented Nov 17, 2018

👍 to fast-track

@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 17, 2018
@gireeshpunathil
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18710/

@Trott
Copy link
Member

Trott commented Nov 18, 2018

Landed in d964d27

@Trott Trott closed this Nov 18, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 18, 2018
@lshanmug @Trott
test: change callback function to arrow function
d964d27 
PR-URL: nodejs#24421
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Nov 18, 2018
@lshanmug @targos
test: change callback function to arrow function
da16376 
PR-URL: #24421
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@lshanmug @rvagg
test: change callback function to arrow function
c177799 
PR-URL: #24421
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Jan 13, 2019
@lshanmug @codebytere
test: change callback function to arrow function
70e7d53 
PR-URL: #24421
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@lshanmug @refack
test: change callback function to arrow function
e1a5a73 
PR-URL: nodejs#24421
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@codebytere codebytere mentioned this pull request Jan 15, 2019
Merged
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@lshanmug @codebytere
test: change callback function to arrow function
39a561b 
PR-URL: #24421
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@oyyd oyyd oyyd approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@lshanmug @targos @gireeshpunathil @Trott @cjihrig @oyyd @trivikr @nodejs-github-bot