-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix linting errors #24229
Closed
Closed
doc: fix linting errors #24229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
errors
Issues and PRs related to JavaScript errors originated in Node.js core.
labels
Nov 7, 2018
Whoops! And thanks! 👍 here to fast-track. |
Trott
approved these changes
Nov 7, 2018
(Insert my usual "wow, let's get that commit queue happening so this sort of stuff doesn't happen" comment.) |
refack
approved these changes
Nov 7, 2018
Landed in 12c0fd4 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 7, 2018
PR-URL: nodejs#24229 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Nov 14, 2018
PR-URL: #24229 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
kiyomizumia
pushed a commit
to kiyomizumia/node
that referenced
this pull request
Nov 15, 2018
PR-URL: nodejs#24229 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
This was referenced Nov 15, 2018
codebytere
pushed a commit
that referenced
this pull request
Nov 29, 2018
PR-URL: #24229 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
PR-URL: #24229 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Dec 3, 2018
PR-URL: #24229 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
doc
Issues and PRs related to the documentations.
errors
Issues and PRs related to JavaScript errors originated in Node.js core.
fast-track
PRs that do not need to wait for 48 hours to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes