-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buffer: fix writeUInt16BE range check #24208
Conversation
0885ec0
to
030f2a6
Compare
CI with test added: https://ci.nodejs.org/job/node-test-pull-request/18383/ |
@addaleax Why would we not land this bug fix on 10.x? |
@mscdex This adds a throw for some input cases, for which we previously had unintended but consistent behaviour, and addressing this doesn’t seem critical. I would say that that disqualifies this for LTS (or technically even might make this semver-major). You can feel free to disagree, and remove the labels, if you feel really strongly about this? |
Fixes: nodejs#24205 PR-URL: nodejs#24208 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Landed in 5c201b6. |
Fixes: #24205 PR-URL: #24208 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Fixes: nodejs#24205 PR-URL: nodejs#24208 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Fixes: #24205 PR-URL: #24208 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Fixes: #24205 PR-URL: #24208 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Fixes: #24205
CI: https://ci.nodejs.org/job/node-test-pull-request/18382/
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes