Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buffer: fix writeUInt16BE range check #24208

Closed
wants to merge 1 commit into from

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Nov 6, 2018

Fixes: #24205

CI: https://ci.nodejs.org/job/node-test-pull-request/18382/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the buffer Issues and PRs related to the buffer subsystem. label Nov 6, 2018
@mscdex mscdex force-pushed the buffer-fix-writeUInt16BE branch from 0885ec0 to 030f2a6 Compare November 6, 2018 23:42
@Trott
Copy link
Member

Trott commented Nov 6, 2018

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 6, 2018
@mscdex
Copy link
Contributor Author

mscdex commented Nov 7, 2018

@addaleax Why would we not land this bug fix on 10.x?

@addaleax
Copy link
Member

addaleax commented Nov 7, 2018

@mscdex This adds a throw for some input cases, for which we previously had unintended but consistent behaviour, and addressing this doesn’t seem critical. I would say that that disqualifies this for LTS (or technically even might make this semver-major).

You can feel free to disagree, and remove the labels, if you feel really strongly about this?

Trott pushed a commit to Trott/io.js that referenced this pull request Nov 8, 2018
Fixes: nodejs#24205

PR-URL: nodejs#24208
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@Trott
Copy link
Member

Trott commented Nov 8, 2018

Landed in 5c201b6.

@Trott Trott closed this Nov 8, 2018
@mscdex mscdex deleted the buffer-fix-writeUInt16BE branch November 9, 2018 02:20
BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
Fixes: #24205

PR-URL: #24208
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
Fixes: nodejs#24205

PR-URL: nodejs#24208
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
codebytere pushed a commit that referenced this pull request Dec 13, 2018
Fixes: #24205

PR-URL: #24208
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants