test: add process no deprecation #24196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
added
process
addaleax
approved these changes
Nov 6, 2018
BridgeAR
approved these changes
Nov 6, 2018
richardlau
reviewed
Nov 6, 2018
| const spawn = require('child_process').spawn; | ||
|
|
||
| // spawn self as child | ||
| const child = spawn(process.argv[0], [process.argv[1], 'child']); |
There was a problem hiding this comment.
Suggested change
| const child = spawn(process.argv[0], [process.argv[1], 'child']); | |
| const child = spawn(process.execPath, [process.argv[1], 'child']); |
lpinca
approved these changes
Nov 6, 2018
| // spawn self as child | ||
| const child = spawn(process.argv[0], [process.argv[1], 'child']); | ||
|
|
||
| child.stderr.setEncoding('utf8'); |
There was a problem hiding this comment.
Suggested change
| child.stderr.setEncoding('utf8'); |
razvanbh
force-pushed
the
fix-no-deprecation
branch
from
c9fadea
to
097fa62
Compare
jasnell
approved these changes
Nov 10, 2018
razvanbh
force-pushed
the
fix-no-deprecation
branch
from
ec8bb0e
to
c0be069
Compare
|
@richardlau @lpinca PTAL |
gireeshpunathil
added
the
author ready
richardlau
approved these changes
Nov 13, 2018
|
landed as 6ae6383 , thanks |
gireeshpunathil
pushed a commit
that referenced
this pull request
Nov 13, 2018
PR-URL: #24196 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Nov 14, 2018
PR-URL: #24196 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
kiyomizumia
pushed a commit
to kiyomizumia/node
that referenced
this pull request
Nov 15, 2018
PR-URL: nodejs#24196 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
This was referenced Nov 15, 2018
codebytere
pushed a commit
that referenced
this pull request
Jan 12, 2019
PR-URL: #24196 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
This was referenced Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes