Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix order of arguments in assert.strictEqual #24145

Closed
wants to merge 1 commit into from
Closed

test: fix order of arguments in assert.strictEqual #24145

wants to merge 1 commit into from

Conversation

eiskalteschatten
Copy link
Contributor

This pull request fixes the order of the arguments for several instances of assert.strictEqual in test/parallel/test-buffer-indexof.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2018
gireeshpunathil
gireeshpunathil reviewed Nov 6, 2018
View reviewed changes
test/parallel/test-buffer-indexof.js
assert.strictEqual(0, bufferString.lastIndexOf('a man a plan a canal panama'));
assert.strictEqual(bufferString.lastIndexOf('canal'), 15);
assert.strictEqual(bufferString.lastIndexOf('panama'), 21);
assert.strictEqual(bufferString.lastIndexOf('a man a plan a canal panama'), 0);
assert.strictEqual(-1, bufferString.lastIndexOf('a man a plan a canal mexico'));
assert.strictEqual(-1, bufferString
.lastIndexOf('a man a plan a canal mexico city'));
assert.strictEqual(-1, bufferString.lastIndexOf(Buffer.from('a'.repeat(1000))));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wondering why some of these were left behind? I guess those can also follow the same change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was task given to me by @BridgeAR which specified the exact line numbers to change. Maybe he can expand upon why he chose them?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just checking whether there is any reason that is unknown to me. no worries, thanks for clarifying.

@addaleax addaleax added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2018
@gireeshpunathil
Copy link
Member

JS lint failure:

$ make lint
make[1]: Entering directory `/home/travis/build/nodejs/node'
Running JS linter...
/home/travis/build/nodejs/node/.eslintrc.js:20
    } catch {
            ^
SyntaxError: Unexpected token {
    at createScript (vm.js:80:10)
    at Object.runInThisContext (vm.js:139:10)
    at Module._compile (module.js:599:28)
    at Object.Module._extensions..js (module.js:646:10)
    at Module.load (module.js:554:32)
    at tryModuleLoad (module.js:497:12)
    at Function.Module._load (module.js:489:3)
    at Module.require (module.js:579:17)
    at require (internal/module.js:11:18)
    at module.exports (/home/travis/build/nodejs/node/tools/node_modules/eslint/node_modules/require-uncached/index.js:28:9)
make[1]: *** [lint-js] Error 2

/cc @nodejs/build

@richardlau
Copy link
Member

@gireeshpunathil #24198

@Trott
Copy link
Member

Trott commented Nov 10, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18486/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 10, 2018
@gireeshpunathil
Copy link
Member

landed as ef907bb

thank you @eiskalteschatten for the contribution! Wish you great success with continued contribution to this project, if you are further interested please have a look at https://www.nodetodo.org/next-steps

gireeshpunathil pushed a commit that referenced this pull request Nov 10, 2018
@eiskalteschatten @gireeshpunathil
test: fix order of arguments in assert.strictEqual
ef907bb 
PR-URL: #24145
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@eiskalteschatten
Copy link
Contributor Author

You're very welcome. I will have a look at the link you posted because I would be interested in contributing more.

BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
@eiskalteschatten @BridgeAR
test: fix order of arguments in assert.strictEqual
bc97b62 
PR-URL: #24145
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Nov 14, 2018
Merged
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
@eiskalteschatten @kiyomizumia
test: fix order of arguments in assert.strictEqual
8254a7d 
PR-URL: nodejs#24145
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
This was referenced Nov 15, 2018
Closed
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Dec 14, 2018
@eiskalteschatten @codebytere
test: fix order of arguments in assert.strictEqual
9f023c4 
PR-URL: #24145
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
@eiskalteschatten @MylesBorins
test: fix order of arguments in assert.strictEqual
9fa7146 
PR-URL: #24145
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@codebytere codebytere mentioned this pull request Jan 4, 2019
Merged
This was referenced Jan 29, 2019
Closed
Closed
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@eiskalteschatten @gireeshpunathil @richardlau @Trott @cjihrig @BridgeAR @addaleax @nodejs-github-bot