Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add shisama to collaborators #24136

Closed
wants to merge 1 commit into from
Closed

doc: add shisama to collaborators #24136

wants to merge 1 commit into from

Conversation

shisama
Copy link
Contributor

@shisama shisama commented Nov 6, 2018 •
edited
Loading

Checklist

Fixes: #23850

@nodejs-github-bot
Copy link
Collaborator

@shisama build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1513/pipeline

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 6, 2018
gireeshpunathil
gireeshpunathil reviewed Nov 6, 2018
View reviewed changes
README.md Outdated Show resolved Hide resolved
gireeshpunathil
gireeshpunathil reviewed Nov 6, 2018
View reviewed changes
README.md Outdated Show resolved Hide resolved
@shisama shisama force-pushed the adding-shisama-as-collaborator branch from 4e5d2a1 to 9229971 Compare November 6, 2018 14:50
@shisama shisama added notable-change PRs with changes that should be highlighted in changelogs. fast-track PRs that do not need to wait for 48 hours to land. labels Nov 6, 2018
@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 6, 2018
@joyeecheung
Copy link
Member

I suggested @shisama to start a full CI, because the bot already kicks off the lite CI pipeline but we need to teach people how to use the CI during the onboarding process

@shisama
Copy link
Contributor Author

shisama commented Nov 6, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18369/

shisama pushed a commit that referenced this pull request Nov 6, 2018
doc: add shisama to collaborators
a49b672 
PR-URL: #24136
Fixes: #23850
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
@shisama
Copy link
Contributor Author

shisama commented Nov 6, 2018

Landed in a49b672

@shisama shisama closed this Nov 6, 2018
targos pushed a commit that referenced this pull request Nov 6, 2018
@targos
doc: add shisama to collaborators
f9f185a 
PR-URL: #24136
Fixes: #23850
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
BridgeAR added a commit that referenced this pull request Nov 14, 2018
@BridgeAR
2018-11-15, Version 11.2.0 (Current)
b0e07c5 
Notable changes:

* child_process:
  * All child processes will again open up a new Window on Windows by
    default. [#24034](#24034)
* deps:
  * A new and fast experimental HTTP parser (`llhttp`) is now supported.
    [#24059](#24059)
* Added new collaborators:
  * [oyyd](https://github.com/oyyd) - Ouyang Yadong.
    [#24300](#24300)
  * [psmarshall](https://github.com/psmarshall) - Peter Marshall.
    [#24170](#24170)
  * [shisama](https://github.com/shisama) - Masashi Hirano.
    [#24136](#24136)
@BridgeAR BridgeAR mentioned this pull request Nov 14, 2018
Merged
BridgeAR added a commit that referenced this pull request Nov 14, 2018
@BridgeAR
2018-11-15, Version 11.2.0 (Current)
f410a6d 
Notable changes:

* child_process:
  * All child processes will again open up a new Window on Windows by
    default. [#24034](#24034)
* deps:
  * A new and fast experimental HTTP parser (`llhttp`) is now supported.
    [#24059](#24059)
* **Windows**
  * A crashing process will now show the names of stack frames if the
    node.pdb file is available.
    [#23822](#23822)
* Added new collaborators:
  * [oyyd](https://github.com/oyyd) - Ouyang Yadong.
    [#24300](#24300)
  * [psmarshall](https://github.com/psmarshall) - Peter Marshall.
    [#24170](#24170)
  * [shisama](https://github.com/shisama) - Masashi Hirano.
    [#24136](#24136)
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
@kiyomizumia
doc: add shisama to collaborators
9977dd4 
PR-URL: nodejs#24136
Fixes: nodejs#23850
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
targos pushed a commit that referenced this pull request Nov 15, 2018
@BridgeAR @targos
2018-11-15, Version 11.2.0 (Current)
a19e1ab 
Notable changes:

* deps:
  * A new experimental HTTP parser (`llhttp`) is now supported.
    #24059
* timers:
  * Fixed an issue that could cause setTimeout to stop working as
    expected. #24322
* Windows
  * A crashing process will now show the names of stack frames if the
    node.pdb file is available.
    #23822
  * Continued effort to improve the installer's new stage that installs
    native build tools.
    #23987,
    #24348
  * child_process:
    * On Windows the `windowsHide` option default was restored to
      `false`. This means `detached` child processes and GUI apps will
      once again start in a new window.
      #24034
* Added new collaborators:
  * [oyyd](https://github.com/oyyd) - Ouyang Yadong.
    #24300
  * [psmarshall](https://github.com/psmarshall) - Peter Marshall.
    #24170
  * [shisama](https://github.com/shisama) - Masashi Hirano.
    #24136
targos pushed a commit that referenced this pull request Nov 15, 2018
@BridgeAR @targos
2018-11-15, Version 11.2.0 (Current)
406d9ca 
Notable changes:

* deps:
  * A new experimental HTTP parser (`llhttp`) is now supported.
    #24059
* timers:
  * Fixed an issue that could cause setTimeout to stop working as
    expected. #24322
* Windows
  * A crashing process will now show the names of stack frames if the
    node.pdb file is available.
    #23822
  * Continued effort to improve the installer's new stage that installs
    native build tools.
    #23987,
    #24348
  * child_process:
    * On Windows the `windowsHide` option default was restored to
      `false`. This means `detached` child processes and GUI apps will
      once again start in a new window.
      #24034
* Added new collaborators:
  * [oyyd](https://github.com/oyyd) - Ouyang Yadong.
    #24300
  * [psmarshall](https://github.com/psmarshall) - Peter Marshall.
    #24170
  * [shisama](https://github.com/shisama) - Masashi Hirano.
    #24136

PR-URL: #24350
This was referenced Nov 15, 2018
Closed
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Nov 29, 2018
@codebytere
doc: add shisama to collaborators
5f14b4e 
PR-URL: #24136
Fixes: #23850
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@MylesBorins
doc: add shisama to collaborators
f80423b 
PR-URL: #24136
Fixes: #23850
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Dec 3, 2018
@MylesBorins
doc: add shisama to collaborators
ec43b32 
PR-URL: #24136
Fixes: #23850
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 6, 2018
@codebytere @MylesBorins
2018-12-11, Version 10.14.2 'Dubnium' (LTS)
4128793 
Notable changes:

* deps:
  * upgrade to c-ares v1.15.0 (Ben Noordhuis)
    #23854
* Windows:
  * A crashing process will now show the names of stack frames if the node.pdb
    file is available. (Refael Ackermann)
    #23822
* Added new collaborators:
  * Peter Marshall. #24170
  * Masashi Hirano. #24136

PR-URL: #24727
MylesBorins pushed a commit that referenced this pull request Dec 11, 2018
@codebytere @MylesBorins
2018-12-11, Version 10.14.2 'Dubnium' (LTS)
6c6c563 
Notable changes:

* deps:
  * upgrade to c-ares v1.15.0 (Ben Noordhuis)
    #23854
* Windows:
  * A crashing process will now show the names of stack frames if the node.pdb
    file is available. (Refael Ackermann)
    #23822
* Added new collaborators:
  * Peter Marshall. #24170
  * Masashi Hirano. #24136

PR-URL: #24727
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@codebytere @refack
2018-12-11, Version 10.14.2 'Dubnium' (LTS)
a2fa589 
Notable changes:

* deps:
  * upgrade to c-ares v1.15.0 (Ben Noordhuis)
    nodejs#23854
* Windows:
  * A crashing process will now show the names of stack frames if the node.pdb
    file is available. (Refael Ackermann)
    nodejs#23822
* Added new collaborators:
  * Peter Marshall. nodejs#24170
  * Masashi Hirano. nodejs#24136

PR-URL: nodejs#24727
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nominating @shisama as a collaborator
8 participants
@shisama @nodejs-github-bot @joyeecheung @targos @cjihrig @gireeshpunathil @vsemozhetbyt @codebytere