Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed console.error to console.log #24112

Closed
wants to merge 2 commits into from
Closed

Changed console.error to console.log #24112

wants to merge 2 commits into from

Conversation

grantcarthew
Copy link
Contributor

A couple of minor documentation changes where console.error was being used when there was no error.

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Nov 5, 2018
doc/api/stream.md Outdated Show resolved Hide resolved
@vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt
Copy link
Contributor

Landed in 85f7af7
Thank you!

vsemozhetbyt pushed a commit that referenced this pull request Nov 10, 2018
* Replace `console.error()` with `console.log()`.
* Fix case and punctuation in logged output.

PR-URL: #24112
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
* Replace `console.error()` with `console.log()`.
* Fix case and punctuation in logged output.

PR-URL: #24112
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
* Replace `console.error()` with `console.log()`.
* Fix case and punctuation in logged output.

PR-URL: nodejs#24112
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
codebytere pushed a commit that referenced this pull request Dec 14, 2018
* Replace `console.error()` with `console.log()`.
* Fix case and punctuation in logged output.

PR-URL: #24112
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
* Replace `console.error()` with `console.log()`.
* Fix case and punctuation in logged output.

PR-URL: #24112
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
@codebytere codebytere mentioned this pull request Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants