Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add optional callback to socket.end #23937

Closed
wants to merge 2 commits into from
Closed

doc: add optional callback to socket.end #23937

wants to merge 2 commits into from

Conversation

Ajido
Copy link
Contributor

@Ajido Ajido commented Oct 28, 2018

Since the optional callback was missing in the socket.end, I added it.

Refs: #18708

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem. labels Oct 28, 2018
@vsemozhetbyt
Copy link
Contributor

CI fails as this ref needs to be updated now. It should be:

[`socket.end()`]: #net_socket_end_data_encoding_callback

@vsemozhetbyt
Copy link
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1401/

@Ajido
Copy link
Contributor Author

Ajido commented Oct 28, 2018

@vsemozhetbyt thank you for your review comments.

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 28, 2018
@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 29, 2018
@vsemozhetbyt
Copy link
Contributor

Landed in 9697c08
Thank you!

vsemozhetbyt pushed a commit that referenced this pull request Oct 29, 2018
@Ajido @vsemozhetbyt
doc: add optional callback to socket.end()
9697c08 
PR-URL: #23937
Refs: #18708
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Nov 1, 2018
@Ajido @targos
doc: add optional callback to socket.end()
f01a806 
PR-URL: #23937
Refs: #18708
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Nov 1, 2018
Merged
This was referenced Nov 2, 2018
Closed
Closed
Closed
Closed
@Ajido Ajido mentioned this pull request Nov 4, 2018
Closed
3 tasks
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
@Ajido @MylesBorins
doc: add optional callback to socket.end()
64c683b 
PR-URL: #23937
Refs: #18708
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@Ajido @rvagg
doc: add optional callback to socket.end()
e14226c 
PR-URL: #23937
Refs: #18708
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 28, 2018
@Ajido @Trott
test: add test for socket.end callback
628f955 
PR-URL: nodejs#24087
Refs: nodejs#23937
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Nov 28, 2018
@Ajido @targos
test: add test for socket.end callback
d6fff0e 
PR-URL: #24087
Refs: #23937
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@Ajido @MylesBorins
doc: add optional callback to socket.end()
cc22a2a 
PR-URL: #23937
Refs: #18708
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@Ajido @refack
test: add test for socket.end callback
f4bd08e 
PR-URL: nodejs#24087
Refs: nodejs#23937
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@Ajido @BethGriggs
test: add test for socket.end callback
4093572 
PR-URL: #24087
Refs: #23937
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@Ajido @rvagg
test: add test for socket.end callback
6799d3b 
PR-URL: #24087
Refs: #23937
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Ajido @vsemozhetbyt @lpinca @trivikr @MylesBorins @nodejs-github-bot