doc: update missing deprecation #23883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
referenced
this pull request
Oct 25, 2018
This is an undocumented utility function that is of questionable utility. Fixes: #18391 PR-URL: #23760 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
richardlau
approved these changes
Oct 25, 2018
|
ugh... forgot about that darn dep code update. |
jasnell
approved these changes
Oct 25, 2018
vsemozhetbyt
approved these changes
Oct 25, 2018
vsemozhetbyt
added
deprecations
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
mmarchini
approved these changes
Oct 25, 2018
4 tasks
trivikr
approved these changes
Oct 26, 2018
lpinca
approved these changes
Oct 26, 2018
|
Green resumed CI: https://ci.nodejs.org/job/node-test-pull-request/18179/ |
The deprecation code was not updated when landing the PR. PR-URL: nodejs#23883 Refs: nodejs#23760 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Apr 23, 2019
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deprecation code was not updated when landing the PR.
Refs: #23760
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes