Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix syntax in doc/api/path.md #23864

Closed
wants to merge 2 commits into from
Closed

doc: fix syntax in doc/api/path.md #23864

wants to merge 2 commits into from

Conversation

ZYSzys
Copy link
Member

@ZYSzys ZYSzys commented Oct 25, 2018

Simply fix typo in doc/api/path.md

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. path Issues and PRs related to the path subsystem. labels Oct 25, 2018
Trott
Trott reviewed Oct 25, 2018
View reviewed changes
doc/api/path.md Outdated
@@ -20,7 +20,7 @@ paths are being used.

For example, using the `path.basename()` function with the Windows file path
`C:\temp\myfile.html`, will yield different results when running on POSIX than
when run on Windows:
when running on Windows:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're in here, how about we take this opportunity to simplify the text? It's needlessly complex. It can probably be joined with the preceding paragraph too. How about just this?:

So using `path.basename()` might yield different results on POSIX and Windows:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm willing to do this.

@Trott
Copy link
Member

Trott commented Oct 25, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1363/

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 25, 2018
@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 25, 2018
@Trott
Copy link
Member

Trott commented Oct 25, 2018

Landed in 16673ae

@Trott Trott closed this Oct 25, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Oct 25, 2018
@ZYSzys @Trott
doc: simplify path.basename() on POSIX and Windows
16673ae 
PR-URL: nodejs#23864
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@ZYSzys ZYSzys deleted the doc/path branch October 26, 2018 00:16
targos pushed a commit that referenced this pull request Oct 26, 2018
@ZYSzys @targos
doc: simplify path.basename() on POSIX and Windows
7a00c98 
PR-URL: #23864
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Oct 27, 2018
Merged
targos pushed a commit that referenced this pull request Nov 1, 2018
@ZYSzys @targos
doc: simplify path.basename() on POSIX and Windows
e241398 
PR-URL: #23864
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This was referenced Nov 2, 2018
Closed
Closed
Closed
Closed
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
@ZYSzys @MylesBorins
doc: simplify path.basename() on POSIX and Windows
2300333 
PR-URL: #23864
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
@ZYSzys @MylesBorins
doc: simplify path.basename() on POSIX and Windows
28ee410 
PR-URL: #23864
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@ZYSzys @rvagg
doc: simplify path.basename() on POSIX and Windows
9afdc09 
PR-URL: #23864
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: James M Snell <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@ZYSzys @rvagg
doc: simplify path.basename() on POSIX and Windows
647c46c 
PR-URL: #23864
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@ZYSzys @MylesBorins
doc: simplify path.basename() on POSIX and Windows
abeba5f 
PR-URL: #23864
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
@BethGriggs BethGriggs mentioned this pull request Dec 4, 2018
Merged
This was referenced Dec 18, 2018
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. path Issues and PRs related to the path subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ZYSzys @Trott @vsemozhetbyt @jasnell @cjihrig @MylesBorins @nodejs-github-bot