Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use more explicit return type in Sign::SignFinal() #23779

Closed
wants to merge 2 commits into from
Closed

src: use more explicit return type in Sign::SignFinal() #23779

wants to merge 2 commits into from

Conversation

addaleax
Copy link
Member

Using the non-indexed variant of std::get<> broke Travis CI.
Also, this allows us to be a bit more concise when returning
from SignFinal() due to some error condition.

Refs: #23427

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax
src: use more explicit return type in Sign::SignFinal()
b004648 
Using the non-indexed variant of `std::get<>` broke Travis CI.
Also, this allows us to be a bit more concise when returning
from `SignFinal()` due to some error condition.

Refs: nodejs#23427
@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1310/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Oct 20, 2018
@addaleax
Copy link
Member Author

addaleax commented Oct 20, 2018 •
edited
Loading

FYI @refack @tniessen

CI: https://ci.nodejs.org/job/node-test-pull-request/18003/ (:heavy_check_mark:)

Feel free to 👍 this comment to approve fast-tracking.

(There’s also #23778, but I think it might be best to talk about those changes independently)

@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 20, 2018
refack
refack reviewed Oct 20, 2018
View reviewed changes
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good idea, but I feel like I need to give it another look tomorrow.

src/node_crypto.h Outdated Show resolved Hide resolved
src/node_crypto.cc Outdated Show resolved Hide resolved
@addaleax
Copy link
Member Author

@refack Done!

@refack
Copy link
Contributor

refack commented Oct 20, 2018

IMHO this is not a clear cut case for fast-tracking, but it does resolve a regression, and the change itself has small footprint. So I'm 👍.
@nodejs/testing for your consideration We need another upvote for fast-tracking (solving the Travis issue).

@refack
Copy link
Contributor

refack commented Oct 20, 2018

This exposed a bug in our release cluster, the arm64 cross compiler (centos7-arm64) is using gcc4.8.

@addaleax
Copy link
Member Author

Landed in 20282b1

@addaleax addaleax closed this Oct 21, 2018
@addaleax addaleax deleted the crypto-no-pair branch October 21, 2018 01:15
addaleax added a commit that referenced this pull request Oct 21, 2018
@addaleax
src: use more explicit return type in Sign::SignFinal()
20282b1 
Using the non-indexed variant of `std::get<>` broke Travis CI.
Also, this allows us to be a bit more concise when returning
from `SignFinal()` due to some error condition.

Refs: #23427

PR-URL: #23779
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
jasnell pushed a commit that referenced this pull request Oct 21, 2018
@addaleax @jasnell
src: use more explicit return type in Sign::SignFinal()
b8cb60f 
Using the non-indexed variant of `std::get<>` broke Travis CI.
Also, this allows us to be a bit more concise when returning
from `SignFinal()` due to some error condition.

Refs: #23427

PR-URL: #23779
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins
Copy link
Contributor

Should this be backported to v10.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

BethGriggs pushed a commit that referenced this pull request Oct 18, 2019
@addaleax @BethGriggs
src: use more explicit return type in Sign::SignFinal()
1bb5102 
Using the non-indexed variant of `std::get<>` broke Travis CI.
Also, this allows us to be a bit more concise when returning
from `SignFinal()` due to some error condition.

Refs: #23427

PR-URL: #23779
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Oct 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@addaleax @nodejs-github-bot @refack @MylesBorins @cjihrig @tniessen @joyeecheung @BethGriggs