Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix index in table of contents in BUILDING.md #23777

Closed
wants to merge 2 commits into from
Closed

doc: fix index in table of contents in BUILDING.md #23777

wants to merge 2 commits into from

Conversation

ZYSzys
Copy link
Member

@ZYSzys ZYSzys commented Oct 20, 2018

This PR fixs the indexing in table of contents in BUILDING.md which was changed by #23490

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Oct 20, 2018
@Trott
Copy link
Member

Trott commented Oct 20, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1311/

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 20, 2018
@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Oct 20, 2018 •
edited
Loading

Maybe you could fix one more nit that slipped in the same PR: add a missing colon after this sentence:

If you want to check the other options, please refer to the help by using
the `--help` option

@ZYSzys
Copy link
Member Author

ZYSzys commented Oct 20, 2018

@vsemozhetbyt Fixed. So seems that we need to resume CI again ?

@Trott
Copy link
Member

Trott commented Oct 20, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1312/

@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 20, 2018
@vsemozhetbyt
Copy link
Contributor

Landed in 3e3ce22
Thank you!

vsemozhetbyt pushed a commit that referenced this pull request Oct 20, 2018
@ZYSzys @vsemozhetbyt
doc: fix index in table of contents in BUILDING.md
3e3ce22 
Also, a missing colon was added.

PR-URL: #23777
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
@ZYSzys ZYSzys deleted the building branch October 20, 2018 08:22
jasnell pushed a commit that referenced this pull request Oct 21, 2018
@ZYSzys @jasnell
doc: fix index in table of contents in BUILDING.md
512faa8 
Also, a missing colon was added.

PR-URL: #23777
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ZYSzys @Trott @vsemozhetbyt @MylesBorins @nodejs-github-bot