Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix coverage generation #23769

Closed
wants to merge 1 commit into from
Closed

build: fix coverage generation #23769

wants to merge 1 commit into from

Commits on Oct 22, 2018

  1. build: fix coverage generation 

    Changes in command line options for nyc resulted in the
coverage target no longer working.

Pin the major version of nyc and update the options to
get it working again.

PR-URL: nodejs#23769
Fixes: nodejs#23690
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: George Adams <[email protected]>
    @mhdawson @refack
    mhdawson authored and refack committed Oct 22, 2018
    Configuration menu
    Copy the full SHA
    ec79b6f View commit details
    Browse the repository at this point in the history