Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix invalid modulesLength during DSA keygen #23732

Closed
wants to merge 1 commit into from
Closed

test: fix invalid modulesLength during DSA keygen #23732

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/parallel/test-crypto-keygen.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ function convertDERToPEM(label, der) {
{
// Test async DSA key generation.
generateKeyPair('dsa', {
modulusLength: 256,
modulusLength: 512,
Copy link
Member

@Trott Trott Oct 18, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

(UPDATE: Previous suggestion removed because I'm not actually sure it's correct and I don't have the ability to test it. It adds complexity anyway, so whatevs.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, openssl just internally increases 256 to 512 (when not FIPs), so always using 512 is no slower and more clear.

divisorLength: 256,
publicKeyEncoding: {
type: 'spki',
Expand Down