tools: do not lint commit message if var undefined #23725

Trott · 2018-10-18T02:23:18Z

Check that $TRAVIS_COMMIT_RANGE is set before trying to lint commit
messages in Travis CI.

Refs: #23572 (comment)
Refs: #22842 (comment)

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Check that $TRAVIS_COMMIT_RANGE is set before trying to lint commit messages in Travis CI. Refs: nodejs#23572 (comment) Refs: nodejs#22842 (comment)

nodejs-github-bot · 2018-10-18T02:23:20Z

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1279/pipeline

Trott · 2018-10-18T05:00:21Z

Since .travis.yml is not exercised in our Jenkins tests, light CI + Travis should suffice.

lpinca · 2018-10-18T06:50:46Z

.travis.yml

@@ -13,7 +13,7 @@ matrix:
      script:
        - make lint
        # Lint the first commit in the PR.
-        - git log $TRAVIS_COMMIT_RANGE --pretty=format:'%h' --no-merges | tail -1 | xargs npx core-validate-commit --no-validate-metadata
+        - \[ -z "$TRAVIS_COMMIT_RANGE" \] || git log $TRAVIS_COMMIT_RANGE --pretty=format:'%h' --no-merges | tail -1 | xargs npx core-validate-commit --no-validate-metadata


I think there is no need to escape [ and ].

[ and ] have special meaning in YAML, so I think you do need to escape at least the opening one, but I'm not sure, so let's try...

#23741 to test

Looks like the result there is malformed YAML and Travis doesn't kick off. Confirmed with https://codebeautify.org/yaml-validator that escaping is needed.

You are right, I was tricked by https://github.com/primus/eventemitter3/blob/991b9454dd977cbfb327203a03885c8f721095e3/.travis.yml and many other similar cases but that works because the whole string is wrapped in ''.

mmarchini

Nice, this should fix #23737

mmarchini · 2018-10-18T19:58:05Z

👍 if you believe this should be fast-tracked (reason: we're having multiple Travis linter failures and this should fix it)

refack · 2018-10-18T23:32:15Z

~~This should land. I don't want to fast-track #23739~~
Landed in 6afaebc

Trott · 2018-10-18T23:33:44Z

Assuming this was closed accidentally?

Check that $TRAVIS_COMMIT_RANGE is set before trying to lint commit messages in Travis CI. Refs: #23572 (comment) Refs: #22842 (comment) PR-URL: #23725 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>

jasnell · 2018-10-18T23:50:06Z

This appears to have landed early with only a single fast-track approval.

Trott · 2018-10-18T23:51:04Z

This appears to have landed early with only a single fast-track approval.

@jasnell In that situation, I assume @mmarchini was in favor of fast-tracking, so that would be two approvals.

jasnell · 2018-10-18T23:54:54Z

Per Collaborator Guide:

The pull request can be landed once two or more Collaborators approve both the pull request and the fast-tracking request, and the necessary CI testing is done.

I would say that @mmarchini's post counts as the "fast-tracking request" and not as an approval.

Trott · 2018-10-19T00:03:40Z

I would say that @mmarchini's post counts as the "fast-tracking request" and not as an approval.

We may be splitting hairs here, but I would say it is both a request and an approval. As the change author, I can make a request, but not an approval. A reviewer can do both, though. At least, that's my interpretation.

Refs: nodejs#23725 (comment)

Refs: #23725 (comment) PR-URL: #23744 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

Check that $TRAVIS_COMMIT_RANGE is set before trying to lint commit messages in Travis CI. Refs: #23572 (comment) Refs: #22842 (comment) PR-URL: #23725 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>

Refs: #23725 (comment) PR-URL: #23744 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

Check that $TRAVIS_COMMIT_RANGE is set before trying to lint commit messages in Travis CI. Refs: #23572 (comment) Refs: #22842 (comment) PR-URL: #23725 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>

Refs: #23725 (comment) PR-URL: #23744 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

Check that $TRAVIS_COMMIT_RANGE is set before trying to lint commit messages in Travis CI. Refs: #23572 (comment) Refs: #22842 (comment) PR-URL: #23725 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>

Refs: #23725 (comment) PR-URL: #23744 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

Check that $TRAVIS_COMMIT_RANGE is set before trying to lint commit messages in Travis CI. Refs: #23572 (comment) Refs: #22842 (comment) PR-URL: #23725 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>

Refs: #23725 (comment) PR-URL: #23744 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

Check that $TRAVIS_COMMIT_RANGE is set before trying to lint commit messages in Travis CI. Refs: #23572 (comment) Refs: #22842 (comment) PR-URL: #23725 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>

Refs: #23725 (comment) PR-URL: #23744 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

tools: do not lint commit message if var undefined

83628a4

Check that $TRAVIS_COMMIT_RANGE is set before trying to lint commit messages in Travis CI. Refs: nodejs#23572 (comment) Refs: nodejs#22842 (comment)

apapirovski approved these changes Oct 18, 2018

View reviewed changes

jasnell approved these changes Oct 18, 2018

View reviewed changes

Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 18, 2018

lpinca approved these changes Oct 18, 2018

View reviewed changes

mmarchini approved these changes Oct 18, 2018

View reviewed changes

richardlau mentioned this pull request Oct 18, 2018

Travis linter false-negatives for commit message checks #23737

Closed

Trott force-pushed the travis-env-check branch from c7be511 to 83628a4 Compare October 18, 2018 23:02

Trott mentioned this pull request Oct 18, 2018

WIP: Do not merge #23741

Closed

4 tasks

Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 18, 2018

refack mentioned this pull request Oct 18, 2018

build,meta: don't fail Travis for commit message #23739

Merged

3 tasks

refack closed this Oct 18, 2018

Trott reopened this Oct 18, 2018

Trott closed this Oct 18, 2018

jasnell added a commit to jasnell/node that referenced this pull request Oct 19, 2018

meta: clarify fast-track approval

c759b56

Refs: nodejs#23725 (comment)

jasnell mentioned this pull request Oct 19, 2018

meta: clarify fast-track approval #23744

Closed

2 tasks

MylesBorins added the land-on-v8.x label Nov 26, 2018

codebytere mentioned this pull request Nov 27, 2018

v10.13.1 proposal #24675

Closed

codebytere mentioned this pull request Nov 29, 2018

v10.14.2 proposal #24727

Merged

BethGriggs mentioned this pull request Dec 4, 2018

v8.14.1 proposal #24832

Merged

Trott deleted the travis-env-check branch January 13, 2022 22:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tools: do not lint commit message if var undefined #23725

tools: do not lint commit message if var undefined #23725

Trott commented Oct 18, 2018

nodejs-github-bot commented Oct 18, 2018

Trott commented Oct 18, 2018

lpinca Oct 18, 2018

Trott Oct 18, 2018

Trott Oct 18, 2018

Trott Oct 18, 2018

lpinca Oct 19, 2018 •

edited

Loading

mmarchini left a comment

mmarchini commented Oct 18, 2018

refack commented Oct 18, 2018 •

edited

Loading

Trott commented Oct 18, 2018

jasnell commented Oct 18, 2018

Trott commented Oct 18, 2018

jasnell commented Oct 18, 2018

Trott commented Oct 19, 2018 •

edited

Loading

tools: do not lint commit message if var undefined #23725

tools: do not lint commit message if var undefined #23725

Conversation

Trott commented Oct 18, 2018

Checklist

nodejs-github-bot commented Oct 18, 2018

Trott commented Oct 18, 2018

lpinca Oct 18, 2018

Choose a reason for hiding this comment

Trott Oct 18, 2018

Choose a reason for hiding this comment

Trott Oct 18, 2018

Choose a reason for hiding this comment

Trott Oct 18, 2018

Choose a reason for hiding this comment

lpinca Oct 19, 2018 • edited Loading

Choose a reason for hiding this comment

mmarchini left a comment

Choose a reason for hiding this comment

mmarchini commented Oct 18, 2018

refack commented Oct 18, 2018 • edited Loading

Trott commented Oct 18, 2018

jasnell commented Oct 18, 2018

Trott commented Oct 18, 2018

jasnell commented Oct 18, 2018

Trott commented Oct 19, 2018 • edited Loading

lpinca Oct 19, 2018 •

edited

Loading

refack commented Oct 18, 2018 •

edited

Loading

Trott commented Oct 19, 2018 •

edited

Loading