Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: coerce PORT to number #23721

Closed
wants to merge 1 commit into from
Closed

benchmark: coerce PORT to number #23721

wants to merge 1 commit into from

Conversation

ofrobots
Copy link
Contributor

@ofrobots ofrobots commented Oct 17, 2018 •
edited
Loading

Without this fix net/tcp-raw-c2s.js aborts in environments where PORT
is defined. TCPWrap::Connect expects the third arg to be a UInt32.

marceline :: ~/src/node ‹v10.x› » PORT=8080 node test/sequential/test-benchmark-net.js
/usr/local/google/home/ofrobots/.nvm/versions/node/v10.12.0/bin/node[152660]: ../src/tcp_wrap.cc:288:static void node::TCPWrap::Connect(const v8::FunctionCallbackInfo<v8::Value>&): Assertion `args[2]->IsUint32()' failed.
 1: 0x8daaa0 node::Abort() [/usr/local/google/home/ofrobots/.nvm/versions/node/v10.12.0/bin/node]
 2: 0x8dab75  [/usr/local/google/home/ofrobots/.nvm/versions/node/v10.12.0/bin/node]
 3: 0x9af98a node::TCPWrap::Connect(v8::FunctionCallbackInfo<v8::Value> const&) [/usr/local/google/home/ofrobots/.nvm/versions/node/v10.12.0/bin/node]
 4: 0xb6114f  [/usr/local/google/home/ofrobots/.nvm/versions/node/v10.12.0/bin/node]
 5: 0xb61ca5 v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**, v8::internal::Isolate*) [/usr/local/google/home/ofrobots/.nvm/versions/node/v10.12.0/bin/node]
 6: 0x2ff8d73dbe1d
/usr/local/google/home/ofrobots/.nvm/versions/node/v10.12.0/bin/node[152680]: ../src/tcp_wrap.cc:288:static void node::TCPWrap::Connect(const v8::FunctionCallbackInfo<v8::Value>&): Assertion `args[2]->IsUint32()' failed.
 1: 0x8daaa0 node::Abort() [/usr/local/google/home/ofrobots/.nvm/versions/node/v10.12.0/bin/node]
 2: 0x8dab75  [/usr/local/google/home/ofrobots/.nvm/versions/node/v10.12.0/bin/node]
 3: 0x9af98a node::TCPWrap::Connect(v8::FunctionCallbackInfo<v8::Value> const&) [/usr/local/google/home/ofrobots/.nvm/versions/node/v10.12.0/bin/node]
 4: 0xb6114f  [/usr/local/google/home/ofrobots/.nvm/versions/node/v10.12.0/bin/node]
 5: 0xb61ca5 v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**, v8::internal::Isolate*) [/usr/local/google/home/ofrobots/.nvm/versions/node/v10.12.0/bin/node]
 6: 0x244d20dbe1d
/usr/local/google/home/ofrobots/.nvm/versions/node/v10.12.0/bin/node[152700]: ../src/tcp_wrap.cc:288:static void node::TCPWrap::Connect(const v8::FunctionCallbackInfo<v8::Value>&): Assertion `args[2]->IsUint32()' failed.
 1: 0x8daaa0 node::Abort() [/usr/local/google/home/ofrobots/.nvm/versions/node/v10.12.0/bin/node]
 2: 0x8dab75  [/usr/local/google/home/ofrobots/.nvm/versions/node/v10.12.0/bin/node]
 3: 0x9af98a node::TCPWrap::Connect(v8::FunctionCallbackInfo<v8::Value> const&) [/usr/local/google/home/ofrobots/.nvm/versions/node/v10.12.0/bin/node]
 4: 0xb6114f  [/usr/local/google/home/ofrobots/.nvm/versions/node/v10.12.0/bin/node]
 5: 0xb61ca5 v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**, v8::internal::Isolate*) [/usr/local/google/home/ofrobots/.nvm/versions/node/v10.12.0/bin/node]
 6: 0x280a178dbe1d
assert.js:350
    throw err;

CI: https://ci.nodejs.org/job/node-test-pull-request/17981/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@ofrobots
benchmark: coerce PORT to number
dde99f3 
Without this fix net/tcp-raw-c2s.js aborts in environments where PORT
is defined. TCPWrap::Connect expects the third arg to be a UInt32.
@nodejs-github-bot
Copy link
Collaborator

@ofrobots build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1277/pipeline

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. http Issues or PRs related to the http subsystem. labels Oct 17, 2018
@ofrobots ofrobots added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 18, 2018
@jasnell
Copy link
Member

jasnell commented Oct 19, 2018

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/17985/

@ofrobots
Copy link
Contributor Author

Another resume build: https://ci.nodejs.org/job/node-test-pull-request/17990/ is green.

@ofrobots
Copy link
Contributor Author

Landed in e5accf5.

@ofrobots ofrobots closed this Oct 19, 2018
@ofrobots ofrobots deleted the benchmarking-port-string branch October 19, 2018 22:07
ofrobots added a commit that referenced this pull request Oct 19, 2018
@ofrobots
benchmark: coerce PORT to number
e5accf5 
Without this fix net/tcp-raw-c2s.js aborts in environments where PORT
is defined. TCPWrap::Connect expects the third arg to be a UInt32.

PR-URL: #23721
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
addaleax pushed a commit that referenced this pull request Oct 20, 2018
@ofrobots @addaleax
benchmark: coerce PORT to number
433507a 
Without this fix net/tcp-raw-c2s.js aborts in environments where PORT
is defined. TCPWrap::Connect expects the third arg to be a UInt32.

PR-URL: #23721
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
jasnell pushed a commit that referenced this pull request Oct 21, 2018
@ofrobots @jasnell
benchmark: coerce PORT to number
996b3c5 
Without this fix net/tcp-raw-c2s.js aborts in environments where PORT
is defined. TCPWrap::Connect expects the third arg to be a UInt32.

PR-URL: #23721
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
@ofrobots @MylesBorins
benchmark: coerce PORT to number
d13bb2c 
Without this fix net/tcp-raw-c2s.js aborts in environments where PORT
is defined. TCPWrap::Connect expects the third arg to be a UInt32.

PR-URL: #23721
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@ofrobots @rvagg
benchmark: coerce PORT to number
f3c32b9 
Without this fix net/tcp-raw-c2s.js aborts in environments where PORT
is defined. TCPWrap::Connect expects the third arg to be a UInt32.

PR-URL: #23721
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@ofrobots @MylesBorins
benchmark: coerce PORT to number
60fe7f1 
Without this fix net/tcp-raw-c2s.js aborts in environments where PORT
is defined. TCPWrap::Connect expects the third arg to be a UInt32.

PR-URL: #23721
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ofrobots @nodejs-github-bot @jasnell @thefourtheye @lpinca @cjihrig @BridgeAR @trivikr