Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: improve README.md #23705

Closed
wants to merge 2 commits into from
Closed

doc: improve README.md #23705

wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 17, 2018

Make text more concise and remove some use of passive voice.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@Trott
doc: improve README.md
3ffdb44 
Make text more concise and remove some use of passive voice.
@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1270/pipeline

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 17, 2018
addaleax
addaleax approved these changes Oct 17, 2018
View reviewed changes
README.md Outdated
@@ -608,7 +606,7 @@ gpg --keyserver pool.sks-keyservers.net --recv-keys DD8F2338BAE7501E3DD5AC78C273
See the section above on [Verifying Binaries](#verifying-binaries) for how to
use these keys to verify a downloaded file.

Previous releases may also have been signed with one of the following GPG keys:
Other keys used to sign some previous releases include:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re: include … we should be clear on whether this is an exhaustive list or not. The previous wording sounded to me like it is?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's an exhaustive list.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I can remove include?: Other keys used to sign some previous releases:

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 18, 2018
@Trott
Copy link
Member Author

Trott commented Oct 18, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1281/

@Trott
Copy link
Member Author

Trott commented Oct 19, 2018

Landed in 15c3366

@Trott Trott closed this Oct 19, 2018
Trott added a commit to Trott/io.js that referenced this pull request Oct 19, 2018
@Trott
doc: improve README.md
15c3366 
Make text more concise and remove some use of passive voice.

PR-URL: nodejs#23705
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
addaleax pushed a commit that referenced this pull request Oct 20, 2018
@Trott @addaleax
doc: improve README.md
493654c 
Make text more concise and remove some use of passive voice.

PR-URL: #23705
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
jasnell pushed a commit that referenced this pull request Oct 21, 2018
@Trott @jasnell
doc: improve README.md
a5b1e7b 
Make text more concise and remove some use of passive voice.

PR-URL: #23705
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
@Trott @MylesBorins
doc: improve README.md
8cd83c5 
Make text more concise and remove some use of passive voice.

PR-URL: #23705
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@Trott @rvagg
doc: improve README.md
3be54ae 
Make text more concise and remove some use of passive voice.

PR-URL: #23705
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@Trott @MylesBorins
doc: improve README.md
535f113 
Make text more concise and remove some use of passive voice.

PR-URL: #23705
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
@Trott Trott deleted the further-readme-simplifications branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell left review comments

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@mmarchini mmarchini mmarchini approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Trott @nodejs-github-bot @refack @jasnell @thefourtheye @addaleax @lpinca @mmarchini @vsemozhetbyt