Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update ESLint to 5.7.0 #23629

Merged
merged 1 commit into from
Oct 15, 2018
Merged

tools: update ESLint to 5.7.0 #23629

merged 1 commit into from
Oct 15, 2018

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Oct 12, 2018

Update ESLint to 5.7.0.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1218/pipeline

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 12, 2018
Trott
Trott approved these changes Oct 12, 2018
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

trivikr
trivikr approved these changes Oct 13, 2018
View reviewed changes
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

thefourtheye
thefourtheye approved these changes Oct 13, 2018
View reviewed changes
Copy link
Contributor

@thefourtheye thefourtheye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the build is happy.

@cjihrig
tools: update ESLint to 5.7.0
ea9df8b 
Update ESLint to 5.7.0.

PR-URL: nodejs#23629
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@cjihrig
Copy link
Contributor Author

cjihrig commented Oct 15, 2018

Green CI: https://ci.nodejs.org/job/node-test-pull-request/17850/

@cjihrig cjihrig merged commit ea9df8b into nodejs:master Oct 15, 2018
@cjihrig cjihrig deleted the eslint branch October 15, 2018 00:13
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@cjihrig @jasnell
tools: update ESLint to 5.7.0
74ebfa3 
Update ESLint to 5.7.0.

PR-URL: #23629
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
addaleax pushed a commit that referenced this pull request Oct 20, 2018
@cjihrig @addaleax
tools: update ESLint to 5.7.0
f9c893a 
Update ESLint to 5.7.0.

PR-URL: #23629
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
@cjihrig @MylesBorins
tools: update ESLint to 5.7.0
6af2f9f 
Update ESLint to 5.7.0.

PR-URL: #23629
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@cjihrig @rvagg
tools: update ESLint to 5.7.0
0ffd39b 
Update ESLint to 5.7.0.

PR-URL: #23629
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@cjihrig @MylesBorins
tools: update ESLint to 5.7.0
9182ad3 
Update ESLint to 5.7.0.

PR-URL: #23629
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thefourtheye thefourtheye thefourtheye approved these changes

@Trott Trott Trott approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cjihrig @nodejs-github-bot @thefourtheye @Trott @trivikr