Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: increased code coverage for slowCases #23592

Closed
wants to merge 1 commit into from
Closed

test: increased code coverage for slowCases #23592

wants to merge 1 commit into from

Conversation

jehaines
Copy link
Contributor

Added test coverage for 4 uncovered if statements in slowCases

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@jehaines
test: increased code coverage for slowCases
8a52c1e 
Added test coverage for 4 un-covered if statements in slowCases
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 12, 2018
@targos targos added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 12, 2018
@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 12, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Oct 15, 2018
@jehaines @BridgeAR
test: increased code coverage for slowCases
9d1c905 
Added test coverage for 4 un-covered if statements in slowCases

PR-URL: nodejs#23592
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Oct 15, 2018
@jehaines @BridgeAR
test: increased code coverage for slowCases
b2e4cb7 
Added test coverage for 4 un-covered if statements in slowCases

PR-URL: nodejs#23592
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BridgeAR
Copy link
Member

Landed in b2e4cb7 🎉

@jehaines congratulations on your commit to Node.js!

@BridgeAR BridgeAR closed this Oct 15, 2018
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@jehaines @jasnell
test: increased code coverage for slowCases
d552598 
Added test coverage for 4 un-covered if statements in slowCases

PR-URL: #23592
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
addaleax pushed a commit that referenced this pull request Oct 20, 2018
@jehaines @addaleax
test: increased code coverage for slowCases
52614ff 
Added test coverage for 4 un-covered if statements in slowCases

PR-URL: #23592
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
@jehaines @MylesBorins
test: increased code coverage for slowCases
e8ca330 
Added test coverage for 4 un-covered if statements in slowCases

PR-URL: #23592
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@jehaines @rvagg
test: increased code coverage for slowCases
25a0b32 
Added test coverage for 4 un-covered if statements in slowCases

PR-URL: #23592
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@jehaines @MylesBorins
test: increased code coverage for slowCases
6d8669c 
Added test coverage for 4 un-covered if statements in slowCases

PR-URL: #23592
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jehaines @BridgeAR @jasnell @cjihrig @trivikr @addaleax @targos @nodejs-github-bot